Repository navigation
Fix And/Or not being commutative when combining rules - #504
Merged
Merged
Conversation
brandhuf
commented
Oct 2, 2026
brandhuf
commented
Contributor
- ArchRule.And/Or and SliceRule.And/Or now pass this instead of _ruleCreator to CombinedArchRule and CombinedArchRuleDefinition
- ArchRuleCreator.HasNoViolations now correctly returns false when RequirePositiveResults is set but no objects matched the predicate
Signed-off-by: Fritz Brandhuber <fritz.brandhuber@tngtech.com>
Signed-off-by: Fritz Brandhuber <fritz.brandhuber@tngtech.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 86.41% 86.45% +0.04%
==========================================
Files 261 261
Lines 12600 12590 -10
Branches 1229 1226 -3
==========================================
- Hits 10888 10885 -3
+ Misses 1372 1366 -6
+ Partials 340 339 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexanderlinne
requested changes
Oct 9, 2026
…nothing Signed-off-by: Fritz Brandhuber <fritz.brandhuber@tngtech.com>
alexanderlinne
requested changes
Oct 9, 2026
Signed-off-by: Fritz Brandhuber <fritz.brandhuber@tngtech.com>
alexanderlinne
approved these changes
Oct 9, 2026
This was referenced Oct 29, 2026
Bump TngTech.ArchUnitNET and TngTech.ArchUnitNET.xUnit
albandvd/EMA-S9-DS-Gestion-des-dependances#11
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.