Repository navigation
Base Slice equality on the identifier alone - #507
Merged
Merged
Conversation
Slice.Equals also compared Types, and IEnumerable<IType> has reference equality, so two slices built from the same identifier over equal but distinct sequences compared as different. A slice is defined by its identifier - the types are derived from it - so comparing them adds nothing but the reference-identity trap. This matters because PlantUmlFileBuilder calls slices.Distinct() and the freeze store deduplicates violations by slice. Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
alexanderlinne
enabled auto-merge
October 9, 2026 09:16
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 86.25% 86.25% -0.01%
==========================================
Files 260 260
Lines 12498 12496 -2
Branches 1219 1218 -1
==========================================
- Hits 10780 10778 -2
Misses 1379 1379
Partials 339 339 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mak638
approved these changes
Oct 9, 2026
This was referenced Oct 26, 2026
Bump TngTech.ArchUnitNET and TngTech.ArchUnitNET.xUnit
albandvd/EMA-S9-DS-Gestion-des-dependances#11
Open
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice.Equals also compared Types, and IEnumerable has reference equality, so two slices built from the same identifier over equal but distinct sequences compared as different. A slice is defined by its identifier - the types are derived from it - so comparing them adds nothing but the reference-identity trap.
This matters because PlantUmlFileBuilder calls slices.Distinct() and the freeze store deduplicates violations by slice.