Skip to content

fix: drop dead imports from generated React templates #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WaryaWayne wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: drop dead imports from generated React templates #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1684db
fix: drop unused React Query imports from generated router
WaryaWayne Jul 29, 2026
9738b2f
fix: drop dead imports from the generated tRPC integration
WaryaWayne Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/router-unused-imports.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
'@tanstack/create': patch
---

Drop unused React Query imports from the generated React `router.tsx`. The
`tanstack-query` branch imported `ReactNode`, `QueryClient` and the
`TanstackQueryProvider` default export whenever the add-on was enabled, but
`ReactNode` and `TanstackQueryProvider` are only referenced inside the tRPC
`Wrap` block and `QueryClient` was never referenced at all. Generated projects
set `noUnusedLocals: true`, so a fresh scaffold shipped code that violates its
own tsconfig. The two tRPC-only imports are now gated behind
`addOnEnabled.tRPC` and the `QueryClient` import is removed.
12 changes: 12 additions & 0 deletions .changeset/trpc-dead-imports.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
'@tanstack/create': patch
---

Drop two dead imports from the generated tRPC integration. `api.trpc.$.tsx`
imported `createServerFileRoute` from `@tanstack/react-start/server`, but the
route was already migrated to `createFileRoute(...)({ server: { handlers } })`
and that symbol is no longer exported, so the leftover import was both unused
and unresolvable. The tRPC branch of `root-provider.tsx` imported
`QueryClientProvider`, which it never renders —
`setupRouterSsrQueryIntegration` supplies the query client. Generated projects
set `noUnusedLocals: true`, so both showed up as errors in a fresh scaffold.
Comment on lines +9 to +12

@coderabbitai coderabbitai Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Correct the query-client description.

getContext() creates the QueryClient; setupRouterSsrQueryIntegration receives that existing client to register SSR query integration. Please adjust this wording so the changeset does not misstate the responsibility of the integration.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.changeset/trpc-dead-imports.md around lines 9 - 12, Update the query-client
description in the changeset so it states that getContext() creates the
QueryClient and setupRouterSsrQueryIntegration receives that existing client to
register SSR query integration, rather than implying the integration supplies or
creates the client.

1 change: 0 additions & 1 deletion packages/create/src/frameworks/react/add-ons/tRPC/assets/src/routes/api.trpc.$.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { createServerFileRoute } from '@tanstack/react-start/server'
import { fetchRequestHandler } from '@trpc/server/adapters/fetch'
import { trpcRouter } from '#/integrations/trpc/router'
import { createFileRoute } from '@tanstack/react-router'
Expand Down
2 changes: 1 addition & 1 deletion ...react/add-ons/tanstack-query/assets/src/integrations/tanstack-query/root-provider.tsx.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% if (addOnEnabled.tRPC) { %>
import type { ReactNode } from 'react'
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'
import { QueryClient } from '@tanstack/react-query'
import superjson from "superjson";
import { createTRPCClient, httpBatchStreamLink } from "@trpc/client";
import { createTRPCOptionsProxy } from "@trpc/tanstack-react-query";
Expand Down
7 changes: 3 additions & 4 deletions packages/create/src/frameworks/react/project/base/src/router.tsx.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import { createRouter as createTanStackRouter } from '@tanstack/react-router'
import { routeTree } from './routeTree.gen'
<% if (addOnEnabled['tanstack-query']) { %>
import type { ReactNode } from 'react'
import { QueryClient } from '@tanstack/react-query'
<% if (addOnEnabled['tanstack-query']) { %><% if (addOnEnabled.tRPC) { %>
import type { ReactNode } from 'react'<% } %>
import { setupRouterSsrQueryIntegration } from "@tanstack/react-router-ssr-query";
import TanstackQueryProvider, { getContext } from './integrations/tanstack-query/root-provider'
import <% if (addOnEnabled.tRPC) { %>TanstackQueryProvider, <% } %>{ getContext } from './integrations/tanstack-query/root-provider'
<% } %>

export function getRouter() {
Expand Down