fix(db): avoid passing computed orderBy aliases to loadSubset#1520
Closed
andrewcoelho wants to merge 1 commit into
Closed
fix(db): avoid passing computed orderBy aliases to loadSubset#1520andrewcoelho wants to merge 1 commit into
andrewcoelho wants to merge 1 commit into
Conversation
Collaborator
|
Closing as superseded per RFC #1657 Phase 0 cleanup. The computed orderBy alias bug no longer reproduces on current main: the PR regression case passes without the production patch, and the alias correctly withholds orderBy/limit pushdown. The regression test remains useful and can be preserved separately as a test-only addition. Thank you for investigating and contributing the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
TLDR: Fixes incorrect
loadSubsetoptimization hints when a subquery orders by a computed selected field e.g.sortKey: coalesce(...).I ran into this when trying to use an
orderByfield that is a projected/computed alias. That was causing subset loading to use an invalid ordering hint, so the top-N window is built from the wrong subset and I observed query results that looked like limit was being applied before orderBy.This change makes ref resolution stop at computed select expressions (only pass-through
refprojections are followed), and only forwardsorderByhints when eachorderByref resolves to a real source field.followRefinpackages/db/src/query/ir.tsto returnundefinedfor computed selected fields.followReffix inpackages/db/src/query/compiler/index.tsto keep compiler behavior consistent.computeSubscriptionOrderByHintsinpackages/db/src/query/live/utils.tsto validate eachorderByref viafollowRefbefore passingorderBy/limithints toloadSubset.packages/db/tests/query/load-subset-subquery.test.tsto ensure computed subqueryorderByaliases do not forwardorderBy/limithints.ETA sample query that shows the issue:
✅ Checklist
pnpm test.🚀 Release Impact