[Feature]: Updater compatibility with minimizing app #719

Activity

1. ViktorScaletta

   added

   enhancementNew feature or requestNew feature or request

   on Oct 23, 2021
2. ViktorScaletta

   assigned

   X1nto

   on Oct 23, 2021
3. X1nto commented on Oct 23, 2021

   

   X1nto

   on Oct 23, 2021

   Member

   More actions

   I was thinking of listening for the Activity's onPause method and launching a Foreground Service that displays a notification and keeps the app alive, but we found out that not many ROMs were friendly with this approach while testing.
4. ViktorScaletta commented on Oct 23, 2021

   

   ViktorScaletta

   on Oct 23, 2021

   Last edited by ViktorScaletta

   Author

   More actions

   @X1nto but why it stopped you from keeping that functionality? You can put a message in the window, that says something like "Some ROMs can kill app anyway".
   And about implementing itself. Described approach is okay and it's used by many apps, such file explorers and others, but I suppose it's unnecessary to run the foreground service on onPause. You can do it immediately after starting update process and do all update-related work there(in background thread, indeed). For update progress to be available you can use Broadcast Receivers(context-registered ones, not ones that use manifest declaration) or any other approaches.
   Actually, there's another approach you can try, but usually it shouldn't be used for such work. I mean WorkManager. All the work can be implemented there and for update progress you can use the same approach I mentioned above. The end of the work can be observed by integrated LiveData functionality.
5. X1nto commented on Oct 23, 2021

   

   X1nto

   on Oct 23, 2021

   Member

   More actions

   @X1nto but why it stopped you from keeping that functionality? You can put a message in the window, that says something like "Some ROMs can kill app anyway".
   And about implementing itself. Described approach is okay and it's used by many apps, such file explorers and others, but I suppose it's unnecessary to run the foreground service on onPause. You can do it immediately after starting update process and do all update-related work there(in background thread, indeed). For update progress to be available you can use Broadcast Receivers(context-registered ones, not ones that use manifest declaration) or any other approaches.
   Actually, there's another approach you can try, but usually it shouldn't be used for such work. I mean WorkManager. All the work can be implemented there and for update progress you can use the same approach I mentioned above. The end of the work can be observed by integrated LiveData functionality.

   WorkManager actually seems like a good alternative to services, I believe they even provide much more functionality. I'll try to implement this for the upcoming 3.0 that's in the compose branch

   👍React with 👍1Reacted by Viktor