Repository navigation
feat(session): read Qoder and Qoder CN sessions - #1571
Conversation
|
No confident findings in the specified PR diff. The description meets the testing requirement: it records a post-build, real-CLI Review was read-only; I did not run, build, or install PR code. |
SaulMoro
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
@huong8373tt-beep Thanks. On a fixture store at 5168c335, session migrate from Qoder into Claude works end to end, and running it again adds no duplicates. The default store paths and the transcript fields match Qoder 1.1.78's npm package. tsc and lint pass. Against #1418, four things block:
- [P1 blocking] CI is red. Every Lint & Test job and the Windows job fail at this head, and I reproduced it locally. The causes:
- 16
agent-session-copycases forqoderandqoder-cnfail because the copy fixture does not create the Qoder store directories. - 6 "every home move" locate guards fail because no locate row sets
QODER_CONFIG_DIRorQODERCN_CONFIG_DIR. readme-matrixandtool-supportalso fail: see the last point.
- 16
- [P1 blocking]
QODER_CLI_HOMEis not read. #1418 names it. With a store underQODER_CLI_HOME/.qoder, the built CLI showsqoder: ✗ not installed. - [P1 blocking] Qoder CN resume names the wrong binary. The PR prints
qodercli --resumefor Qoder CN. The CN package (@qodercn-ai/qoderclicn) installsqoderclicn. I checked this in the package's bin entry; I did not run a resume. - [P1 blocking] README and generated docs are out of date. The Qoder and Qoder CN scorers cells read
✓³in all five READMEs and should read✓. The tool-support pages neednpx vitest run tool-support -u.
Non-blocking:
- [P2 non-blocking]
docs/guide/dashboard.mdand its zh-CN page do not list the two new platforms.
The CI review reported no confident findings. All four points above reproduce.
@jeff-r2026 Your call once these are fixed.
|
No confident findings in the specified PR diff. The PR description meets the testing requirement: it records a post-build, real-CLI The earlier review raised no findings, so none require resolution. Review was read-only; I did not run, build, or install PR code. |
|
P1 fixes are pushed at |
|
No confident findings in the specified PR diff. The PR description meets the testing requirement: it records a post-build, real-CLI Earlier reviews raised no findings, so none require resolution. Review was read-only and limited to the specified diff; I did not run, build, or install PR code. |
|
Follow-up for the Windows CI failure: the failing |
SaulMoro
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
@huong8373tt-beep Thanks. At 902312db, with the built CLI, a Qoder store under QODER_CLI_HOME/.qoder now shows qoder: ✓ installed. Qoder CN resume names qoderclicn, matching the package's bin entry; I did not run a resume. The README ✓ cells, the tool-support pages and the dashboard docs are fixed, and the Windows job is green after the new locate rows.
One thing still blocks:
- [P1 blocking] Qoder CN ignores
QODERCN_CLI_HOME. It is the CN half of theQODER_CLI_HOMEpoint. The Qoder CN package README lists it third in priority, afterQODERCN_CONFIG_DIR, with the directory name appended. With a store underQODERCN_CLI_HOME/.qoder-cn, the built CLI showsqoder-cn: ✗ not installed, so its sessions do not appear andsession migrate -t qoder-cnrefuses. MirroringqoderHomeinqoderCnHome(src/tool-home.ts:124) fixes it; the locate matrix helper,homeVariables,tool-support.tsand the generated tool-support pages need the same variable.
Independent of this PR: neither main nor this head reads QODER_CONFIG_DIR_NAME / QODERCN_CONFIG_DIR_NAME, which rename the default directory.
Lint & Test and the fork-safe E2E shards were still running at 902312db when I checked.
@jeff-r2026 Your call once this is fixed and CI is green.
|
Addressed the remaining P1 at Validation:
The earlier fixture-based built-CLI validation remains documented in the PR body. No credentials or external service access are required. |
|
No confident findings in the specified PR diff. The PR description meets the testing requirement: it records a post-build, real-CLI Earlier reviews raised no findings, so none require resolution. Review was read-only and limited to the specified diff; I did not run, build, or install PR code. |
SaulMoro
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
@huong8373tt-beep Thanks. At c938e7b9, qoderCnHome reads QODERCN_CLI_HOME/.qoder-cn after QODERCN_CONFIG_DIR, the same way qoderHome does for Qoder, and homeVariables, the locate rows, tool-support.ts and the generated pages carry the new variable. That closes the last blocking point; I checked it by reading the change.
Nothing else blocks from my side once CI is green. Lint & Test and the E2E shards were still running when I checked.
@jeff-r2026 Your call once CI is green.
SaulMoro
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Approving at c938e7b9: the Qoder and Qoder CN blockers are fixed, the README scorers marks, tool-support pages and dashboard platform list match, and CI is green. I changed the description's Closes #1418 to "Part of #1418", since the issue tracks the other tools too.
@huong8373tt-beep Thanks for working through every round.
Part of #1418: the Qoder and Qoder CN row. The issue stays open for the other tools.
What changed
QODER_CONFIG_DIR,QODER_CLI_HOME/.qoder,QODERCN_CONFIG_DIR, andQODERCN_CLI_HOME/.qoder-cn.qoderclicn --resume.teamai session platformsand the existing AgentSession list/find/migrate flow.Validation
npm run typecheck— passed.npm run lint— passed with 0 warnings / 0 errors.npm run build— passed.git diff --check— passed.Built CLI verification
After building the current
dist/cli.js, ranteamai session platformswith isolated Qoder and Qoder CN configuration roots and project stores. The built CLI reported bothqoderandqoder-cnas installed. The session migration fixture was also exercised end to end; running the migration twice does not create duplicates.At the current head, a separate isolated CLI run with only
QODERCN_CLI_HOMEset and a store atQODERCN_CLI_HOME/.qoder-cn/projectsreportsqoder-cn: ✓ installed.Fixture-based verification in this PR uses checked-in synthetic transcript data and isolated local configuration directories; it does not require credentials or external service access.
Disclosure and authorization
Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.