Repository navigation
docs(setup): list internal Claude instruction files - #1588
Conversation
|
No findings in the specified diff. The change is documentation-only, and the PR description records |
|
No findings in the specified diff. The change is documentation-only and limited to listing the internal Claude instruction files. The PR description records The earlier review raised no findings, so there are none to mark resolved. |
SaulMoro
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Thanks, the gap is real: #1318 (c3bf248e) added .claude-internal/CLAUDE.md and .tclaude/CLAUDE.md to the delivered exclude block, and this page didn't say so. The CI review reported no findings.
One wording point before merge, since this page is what an agent reads when it answers an admin:
[P2 non-blocking] The instruction files belong with the shared files, not the delivered ones. #1318 excludes them only while they hold teamai's blocks alone: once a member adds their own text, or the file is tracked, it stays visible (its e2e test checks exactly that). As written, they sit in the list of files that are always excluded, before the "while it holds only teamai's entries" clause. Moving them into the shared-file group keeps the page accurate; a suggestion is on the lines.
Happy to approve once that's in.
| member adds to a delivered skill stays visible), agents, `CLAUDE.md` instruction | ||
| files (including `.claude-internal/CLAUDE.md` and `.tclaude/CLAUDE.md`), | ||
| `teamai-context` files, hook files and team docs (one file per line) it delivered | ||
| into a project, and each shared config file (MCP, `.codex/hooks.json`, OpenCode's) | ||
| while it holds only teamai's entries, in teamai's `delivered` block in the clone's |
There was a problem hiding this comment.
| member adds to a delivered skill stays visible), agents, `CLAUDE.md` instruction | |
| files (including `.claude-internal/CLAUDE.md` and `.tclaude/CLAUDE.md`), | |
| `teamai-context` files, hook files and team docs (one file per line) it delivered | |
| into a project, and each shared config file (MCP, `.codex/hooks.json`, OpenCode's) | |
| while it holds only teamai's entries, in teamai's `delivered` block in the clone's | |
| member adds to a delivered skill stays visible), agents, `teamai-context` files, hook | |
| files and team docs (one file per line) it delivered into a project, and each shared | |
| file (MCP config, `.codex/hooks.json`, OpenCode's config, and the `CLAUDE.md` instruction | |
| files, including `.claude-internal/CLAUDE.md` and `.tclaude/CLAUDE.md`) while it holds | |
| only teamai's entries, in teamai's `delivered` block in the clone's |
|
Addressed the review wording point in |
|
No findings in the specified diff. The change is documentation-only and limited to listing the internal Claude instruction files. The PR description records Earlier reviews raised no findings, so there are none to mark resolved. |
SaulMoro
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Approving at adda1dc. The CLAUDE.md instruction files now sit with the shared config files, which are excluded only while they hold only teamai's entries. That matches how pull treats them. Docs only, no other change since the last review.
|
Thanks for the approval and the wording correction. The follow-up commit |
Summary
The admin guidance for
sharing.gitExclude.enabledlisted delivered agents, context, hooks, docs, and shared config files, but omitted the internal Claude instruction files that TeamAI already excludes after #1318.This documentation-only change explicitly includes:
.claude-internal/CLAUDE.md.tclaude/CLAUDE.mdThis aligns the shipped setup/admin reference with the delivered-file behavior and avoids leaving maintainers unsure whether those files remain visible to
git add -A.Refs #1221.
Type of Change
Validation
git diff --checkNo runtime behavior or generated artifacts change.
Disclosure and authorization
Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.