Skip to content

docs(setup): list internal Claude instruction files - #1588

Merged
jeff-r2026 merged 2 commits into
Tencent:mainfrom
huong8373tt-beep:teamai-cli-1221-docs
Oct 30, 2026
Merged

jeff-r2026 merged 2 commits into
Tencent:mainfrom
huong8373tt-beep:teamai-cli-1221-docs

Conversation

@huong8373tt-beep

Copy link
Copy Markdown
Contributor

Summary

The admin guidance for sharing.gitExclude.enabled listed delivered agents, context, hooks, docs, and shared config files, but omitted the internal Claude instruction files that TeamAI already excludes after #1318.

This documentation-only change explicitly includes:

  • .claude-internal/CLAUDE.md
  • .tclaude/CLAUDE.md

This aligns the shipped setup/admin reference with the delivered-file behavior and avoids leaving maintainers unsure whether those files remain visible to git add -A.

Refs #1221.

Type of Change

  • Documentation only

Validation

  • git diff --check
  • Verified the updated shipped setup reference contains both internal-Claude paths.

No runtime behavior or generated artifacts change.

Disclosure and authorization

Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.

@github-actions

Copy link
Copy Markdown

No findings in the specified diff.

The change is documentation-only, and the PR description records git diff --check plus verification of both internal-Claude paths. This is sufficient under the trusted review rules; no end-to-end or real-CLI record is required.

@SaulMoro
SaulMoro marked this pull request as ready for review October 30, 2026 13:47
@github-actions

Copy link
Copy Markdown

No findings in the specified diff.

The change is documentation-only and limited to listing the internal Claude instruction files. The PR description records git diff --check and verification of both paths, which is sufficient under the trusted review rules; no end-to-end or real-CLI record is required.

The earlier review raised no findings, so there are none to mark resolved.

@SaulMoro SaulMoro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated by AI during triage.

Thanks, the gap is real: #1318 (c3bf248e) added .claude-internal/CLAUDE.md and .tclaude/CLAUDE.md to the delivered exclude block, and this page didn't say so. The CI review reported no findings.

One wording point before merge, since this page is what an agent reads when it answers an admin:

[P2 non-blocking] The instruction files belong with the shared files, not the delivered ones. #1318 excludes them only while they hold teamai's blocks alone: once a member adds their own text, or the file is tracked, it stays visible (its e2e test checks exactly that). As written, they sit in the list of files that are always excluded, before the "while it holds only teamai's entries" clause. Moving them into the shared-file group keeps the page accurate; a suggestion is on the lines.

Happy to approve once that's in.

Comment on lines +226 to +230
member adds to a delivered skill stays visible), agents, `CLAUDE.md` instruction
files (including `.claude-internal/CLAUDE.md` and `.tclaude/CLAUDE.md`),
`teamai-context` files, hook files and team docs (one file per line) it delivered
into a project, and each shared config file (MCP, `.codex/hooks.json`, OpenCode's)
while it holds only teamai's entries, in teamai's `delivered` block in the clone's

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
member adds to a delivered skill stays visible), agents, `CLAUDE.md` instruction
files (including `.claude-internal/CLAUDE.md` and `.tclaude/CLAUDE.md`),
`teamai-context` files, hook files and team docs (one file per line) it delivered
into a project, and each shared config file (MCP, `.codex/hooks.json`, OpenCode's)
while it holds only teamai's entries, in teamai's `delivered` block in the clone's
member adds to a delivered skill stays visible), agents, `teamai-context` files, hook
files and team docs (one file per line) it delivered into a project, and each shared
file (MCP config, `.codex/hooks.json`, OpenCode's config, and the `CLAUDE.md` instruction
files, including `.claude-internal/CLAUDE.md` and `.tclaude/CLAUDE.md`) while it holds
only teamai's entries, in teamai's `delivered` block in the clone's

@huong8373tt-beep

Copy link
Copy Markdown
Contributor Author

Addressed the review wording point in adda1dca: internal Claude instruction files now appear with the shared-file group, and the text clarifies they are excluded only while they contain TeamAI-managed entries. Member-owned or edited content remains visible, matching the existing behavior and E2E coverage.

@github-actions

Copy link
Copy Markdown

No findings in the specified diff.

The change is documentation-only and limited to listing the internal Claude instruction files. The PR description records git diff --check and verification of both paths, which is sufficient under the trusted review rules; no end-to-end or real-CLI record is required.

Earlier reviews raised no findings, so there are none to mark resolved.

@SaulMoro SaulMoro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated by AI during triage.

Approving at adda1dc. The CLAUDE.md instruction files now sit with the shared config files, which are excluded only while they hold only teamai's entries. That matches how pull treats them. Docs only, no other change since the last review.

@jeff-r2026 jeff-r2026 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only. Merged onto main cd9f327 cleanly; tsc/lint/build pass there. Wording matches #1318's behavior (instruction files excluded only while they hold only teamai's entries). CI green.

@jeff-r2026
jeff-r2026 merged commit ca2c583 into Tencent:main Oct 30, 2026
18 checks passed
@huong8373tt-beep

Copy link
Copy Markdown
Contributor Author

Thanks for the approval and the wording correction. The follow-up commit adda1dca places the internal Claude instruction files with the shared-file group and clarifies that they are excluded only while they contain TeamAI-managed entries; member-owned or tracked content remains visible. No further changes are needed on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants