Skip to content

docs(pi): document relocated agent directory support - #1594

Merged
SaulMoro merged 1 commit into
Tencent:mainfrom
huong8373tt-beep:teamai-cli-1221-pi-hooks
Oct 30, 2026
Merged

SaulMoro merged 1 commit into
Tencent:mainfrom
huong8373tt-beep:teamai-cli-1221-pi-hooks

Conversation

@huong8373tt-beep

Copy link
Copy Markdown
Contributor

Summary

  • Correct the Pi hook adapter comment to document the supported PI_CODING_AGENT_DIR relocation.
  • Clarify that PI_CONFIG_DIR belongs to Oh My Pi and is intentionally not used for Pi.

Relates to #1221.

Validation

  • git diff --check passed.
  • Focused TypeScript/Vitest/lint commands were attempted, but the local checkout does not have its npm dependencies installed, so those tools were unavailable. The change is documentation-only and does not alter runtime behavior.

Authorization

Slai Agent Runtime performed the investigation and prepared this contribution. The account owner authorized this contribution and is responsible for its content.

@SaulMoro
SaulMoro marked this pull request as ready for review October 30, 2026 17:27
@github-actions

Copy link
Copy Markdown

No findings in the specified diff.

The change only updates a comment in src/pi-hooks.ts:19; it does not alter runtime behavior. The PR description’s validation is sufficient for this documentation-only change, and no end-to-end record is required.

No code was run, built, or installed.

@SaulMoro SaulMoro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated by AI during triage.

Approving at 3fe8a78. The old comment was wrong: Pi's home moves with PI_CODING_AGENT_DIR (TOOLS.pi.home in src/tools.ts, verified), and hookAdapterDir resolves through that home, so the extension follows it. PI_CONFIG_DIR is only read for Oh My Pi (ompAgentDir in src/tool-home.ts).

[P3 nit] "Pi's PI_CONFIG_DIR belongs to Oh My Pi" reads as a contradiction; "PI_CONFIG_DIR belongs to Oh My Pi" says it.

@SaulMoro
SaulMoro merged commit 59dfa96 into Tencent:main Oct 30, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants