Skip to content

fix(codebase): keep wiki lint output in English - #1653

Merged
SaulMoro merged 1 commit into
Tencent:mainfrom
XY-code1:fix/wiki-lint-english
Nov 1, 2026
Merged

SaulMoro merged 1 commit into
Tencent:mainfrom
XY-code1:fix/wiki-lint-english

Conversation

@XY-code1

@XY-code1 XY-code1 commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • translate every user-visible Chinese diagnostic in codebase --lint to English
  • keep graph health headings, issue details, clean results, and severity totals consistent with the CLI's English-only output rule
  • add regression tests for both a missing/broken teamwiki and a healthy teamwiki, including a no-CJK assertion

This is the focused output fix noted on #836. The remaining anti-slop lint-rule work stays out of scope.

Testing

  • npx vitest run src/__tests__/codebase-wiki-lint.test.ts --maxWorkers=1 — 2 passed
  • npm run typecheck — passed
  • targeted type-aware oxlint on the changed production and test files — passed
  • npm run build — passed
  • git diff --check — passed

Real CLI verification against an empty teamwiki/:

$ node dist/cli.js codebase --lint --output .
=== teamwiki/ knowledge graph health check ===

Graph: 0 nodes, 0 edges, connectivity 0%

[graph-missing] (1)
  [high] teamwiki/.indices/graph-index.json: graph-index.json does not exist; the knowledge graph has not been built

[evidence-missing] (1)
  [high] teamwiki/evidence/code/: The evidence directory does not exist; no code fact pages are available

[nav-missing] (3)
  [low] teamwiki/router.md: Navigation file router.md does not exist; the knowledge base entry point is incomplete
  [low] teamwiki/index.md: Navigation file index.md does not exist; the knowledge base entry point is incomplete
  [low] teamwiki/hot.md: Navigation file hot.md does not exist; the knowledge base entry point is incomplete

[manifest-missing] (1)
  [low] teamwiki/source-manifest.json: source-manifest.json does not exist; incremental updates are unavailable

Total: 2 high, 0 medium, 4 low, 0 info
EXIT=1

Exit 1 is expected because the fixture has high-severity findings.

The repository-wide npm run lint completes its oxlint phase, then the documentation checker reports generated/default-workflow documentation already stale on the base revision. This change does not touch commands, descriptors, workflows, or documentation.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

No findings in the specified diff. The changes are focused English translations with regression tests; I found no concrete bugs introduced.

The PR description includes sufficient testing, including a representative real-CLI run with the expected exit code of 1.

Review was read-only; I did not run, build, or install anything from the PR.

@SaulMoro SaulMoro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated by AI during triage.

Approving at ee84d17e. Every Chinese message and heading in src/codebase-wiki-lint.ts is now English, with the same categories, severities and locations; the file has no Han characters left, and nothing else in src/, docs/ or skill-data/ quoted the old text. The description's built-CLI run on an empty teamwiki shows the English report and the unchanged exit 1.

#1637 also edits formatWikiLintReport (it adds a "not checked" graph line, currently in Chinese); whichever merges second needs a rebase, and that line should follow this one's English.

@SaulMoro
SaulMoro merged commit d2230c9 into Tencent:main Nov 1, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants