Repository navigation
fix(dashboard): localize remaining hardcoded Chinese UI strings (browser AI panel, skill recording, PWA guides) - #1799
Merged
jubaoliang merged 1 commit intoOct 8, 2026
Conversation
English users still saw Chinese text in the browser AI assistant panel, skill recording/replay chat messages, the PWA install guide, MBTI persona tags, and the collapsed sidebar update badge. Route these strings through the existing i18n keys where present, add new keys to both locale files, and cover the skill-record workflow hook and pending-message handler.
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #1720. In the English UI several dashboard surfaces still rendered hardcoded Chinese because the strings never went through i18n. This PR covers the reporter's scenario (browser AI assistant / skill recording) plus a few other visible spots:
BrowserAiPanel): all chat messages and toasts pushed during skill recording/replay (objective set, recording preview + truncation notice, failed script generation, skill applied, replay started/done/failed, in-progress hint) now go throught(). The trigger keyword lists (结束/确认/end/confirm…) stay hardcoded on purpose — those match what the user types, not UI copy.useSkillRecordingWorkflow,useChatSend): same messages pushed from the Chat page and the pending-message auto-record path.PwaInstallPrompt): button label/tooltip and the iOS / desktop install guide sheets.MbtiPersonaTag): replaced the hardcoded ZH/EN name maps withmbti.*translation keys (labels now follow the active language through i18next instead of ani18n.language === "zh"check).~60 keys were added to both
en.jsonandzh.json; where a suitable key already existed (skillRecord.*,browser.recordReplay.*) it is reused instead of duplicating. Both locale files stay in parity (6019 keys, same{{placeholder}}sets).Remaining hardcoded strings elsewhere in the dashboard (~600, mostly debug/PWA diagnostics, connectors, attachments lists) are untouched here and can follow in separate PRs to keep this reviewable.
Target branch
develop(feature / fix — default)Type of change
Test plan
npx tsc -b— cleannpx eslinton all changed files — cleannpx prettier --checkon all changed files — cleannpx vitest run— 1145 passed, 8 failed; the 8 failures are pre-existing on an unmodified checkout in this environment (useSessions,skillMarkdown,SkillDrawer,knowledgeBases,publishedExperts,docxSanitize) and unrelated to this diffVerified
en.json/zh.jsonkey parity (6019 keys each, 0 one-sided) and placeholder parity for every key touchedmake allpasses locally (could not run the full Python stack in this environment — dashboard checks above were run instead)Added/updated tests
Checklist
CHANGELOG.md(if user-facing)