chore: update Meziantou.Analyzer to 3.0.290 - #1115
Merged
Merged
Conversation
Suppress the new MA0054 warning where the mocks deliberately rethrow `UnauthorizedAccessException` as an `IOException` without an inner exception, to keep the mock behavior unchanged.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The valid dependency update and narrowly scoped suppressions preserve existing behavior without unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Meziantou.Analyzer while preserving intentional mock exception behavior.
Changes:
- Updates the analyzer from 3.0.266 to 3.0.290.
- Suppresses MA0054 at two deliberate exception translations.
| File | Description |
|---|---|
Directory.Packages.props |
Updates the analyzer version. |
Source/Testably.Abstractions.Testing/FileSystem/DirectoryMock.cs |
Suppresses MA0054 for directory deletion. |
Source/Testably.Abstractions.Testing/FileSystem/DirectoryInfoMock.cs |
Suppresses MA0054 for directory-info deletion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Test Results 62 files ±0 62 suites ±0 1h 20m 38s ⏱️ + 2m 35s Results for commit 17d3568. ± Comparison against base commit 955dbd4. This pull request removes 62988 and adds 62984 tests. Note that renamed tests count towards both.This pull request removes 6893 skipped tests and adds 6893 skipped tests. Note that renamed tests count towards both. |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
This is addressed in release v7.1.1. |
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress the new MA0054 warning where the mocks deliberately rethrow
UnauthorizedAccessExceptionas anIOExceptionwithout an inner exception, to keep the mock behavior unchanged.