unify(legacy-profiler): Make both games inherit legacy profiler - #3075
Closed
Jaredl-Dev wants to merge 1 commit into
Closed
unify(legacy-profiler): Make both games inherit legacy profiler#3075Jaredl-Dev wants to merge 1 commit into
Jaredl-Dev wants to merge 1 commit into
Conversation
Jaredl-Dev
added a commit
to Jaredl-Dev/GeneralsGameCode
that referenced
this pull request
Aug 7, 2026
Jaredl-Dev
force-pushed
the
unify/profilelegacy
branch
2 times, most recently
from
August 7, 2026 21:17
bbaf309 to
2f3f26a
Compare
Jaredl-Dev
changed the title
Jaredl-Dev
force-pushed
the
unify/profilelegacy
branch
from
August 7, 2026 21:24
2f3f26a to
919d16e
Compare
xezon
reviewed
Aug 8, 2026
| ) | ||
|
|
||
| target_link_libraries(core_profile_legacy PRIVATE | ||
| core_debug |
There was a problem hiding this comment.
I don't think this is right.
Should mirror GeneralsMD first. core_debug and core_profile_legacy is linked in 3 game targets.
Author
There was a problem hiding this comment.
Perhaps I should revise this PR to implement the suggestion from #3070 (comment), and then move the changes to Core in a third commit within #3070?
There was a problem hiding this comment.
It does not need to be a separate commit. Whereever you merge the profile code to Generals, just merge the lib linking as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes both GameEngine builds inherit
core_profile_legacyand declarescore_debugas its private dependency.Prerequisite for #3070
#3070 moves
Shell.cppinto Core, where profile builds callProfile::StopRange("init").Zero Hour already linked the legacy profiler, but Generals did not, causing an unresolved
Profile::StopRangesymbol when linkinggeneralsv.exe. This PR provides the shared dependencies required by #3070.Verification