You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wanted this too, but it wasn't supported, so I've added a PR#107 #107. That's failing right now but not on the additions I made. When I forked the repo and ran the tests, one test was failing (dateFacade.getHumanReadableTimestamp was returning a different format) so I fixed it before submitting the PR, but that test is now failing on Travis. That function just returns .toLocaleString() so presumably that gives a different answer on the CI setup. It's odd, because the docs for toLocaleString() say it should give the format I put in the test...
Activity
haylingsailor commentedon Mar 21, 2017
I wanted this too, but it wasn't supported, so I've added a PR#107 #107. That's failing right now but not on the additions I made. When I forked the repo and ran the tests, one test was failing (dateFacade.getHumanReadableTimestamp was returning a different format) so I fixed it before submitting the PR, but that test is now failing on Travis. That function just returns .toLocaleString() so presumably that gives a different answer on the CI setup. It's odd, because the docs for toLocaleString() say it should give the format I put in the test...
haylingsailor commentedon Mar 21, 2017
PR now passes tests...