Skip to content

Test wallet plan retries while reset vouchers are loading - #14

Open
LIghtJUNction wants to merge 2 commits into
mainfrom
test/wallet-subscription-voucher-loading
Open

LIghtJUNction wants to merge 2 commits into
mainfrom
test/wallet-subscription-voucher-loading

Conversation

@LIghtJUNction

@LIghtJUNction LIghtJUNction commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

The wallet disclosure on main contains two independently loaded views. A failed plans request can show its local error and Retry button while the banked reset voucher request still shows Loading. The previous assertion scanned the whole disclosure. The failing Web job tested merge commit 07573d0fb2e20bc953dc1ba0f67cbadd32827986 and showed both states in the same string.

The test holds the synthetic reset voucher request pending through the plan error and retry. It checks the plan error, Retry button and confirmed empty results within the subscriptions card. It separately checks the voucher loading status, releases that request, and waits for the voucher empty state. The request counts cover both plan reads before and after retry and the single voucher read.

On base 1f8566fcd132fe2c9c448400cc078d3edbab12fc, holding the voucher pending reproduced the original assertion failure. With the change, the targeted test passed five consecutive fresh Bun processes, all 12 tests in the wallet file passed, and the Web TypeScript build and file formatting check passed. Tests used Bun 1.3.14 and synthetic responses.

The hosted Web checks and production build passed on dad5c195f591beeafce8246d1a300698a248ad7f. The wallet regression passed, and the serial Web suite completed all 765 source test files and 6 script test files.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-22T17:01:53.072109Z 65fccb8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants