Repository navigation
Fix FX conversion for platform-credit top-ups - #754
Closed
LIghtJUNction wants to merge 1 commit into
Closed
LIghtJUNction wants to merge 1 commit into
LIghtJUNction wants to merge 1 commit into
Conversation
Member
Author
|
代码审查阻断(2026-10-11,基于 请不要在未统一对账单位之前直接合并。本修复需要保留冻结平台计量单位与资金结算汇率的独立性,覆盖 CNY/USD、自定义网关、平台积分到钱包 quota、冻结订单金额、回调幂等,以及已有测试中的非 1 比例。请使用隔离测试数据给出支付金额/到账额度对账矩阵。当前 PR 仅将输出常数化不足以证明不存在低价套利,还可能导致多收或少收。 |
This was referenced Oct 10, 2026
Merged
LIghtJUNction
marked this pull request as ready for review
October 11, 2026 12:29
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
按维护者要求关闭过时修复分支;相关问题将基于最新 main 重新核验和修复。本次关闭不代表问题已修复。 |
LIghtJUNction
deleted the
codex/fix-fx-conversion-for-platform-credit-top-ups
branch
November 5, 2026 07:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
platform_units_per_usdfrom the display FX (CNY/custom) which caused non-USD purchases to be undercharged while persisting the full USD-denominated credited quota.Description
decimal.NewFromInt(1)fromconfiguredPlatformUnitsPerUSD()so platform credits remain USD-denominated accounting units.apps/api-go/controller/topup.gowith clarifying comments that display/settlement FX affect only the fiat charge, not the platform-unit purchase rate.Testing
cd apps/api-go && go test ./controller -run TestQuoteTopUpSupportsExplicitFXAndLegacyDirectPricing -count=1, which completed without failures.gofmt -won the modified file and validated the local test invocation returned clean results.Codex Task