Repository navigation
Conversation
buildThreadGraph filled depthById for every reply but never read it; the depth is already stored on each reply as reply.depth. Claude-Session: https://claude.ai/code/session_01W9Mk18mBNfkPfgg3hYweKq
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
buildThreadGraphinapps/comments-ui/src/utils/thread-graph.tsfills adepthByIdmap for every reply and never reads it:Those are the only two occurrences of
depthByIdin the repository. The same value is written onto the reply itself one line earlier (reply.depth = depth), and every later depth lookup in the file (getAncestorAtDepth,getWindowForComment) readsreply.depth/current.depth.What
Removes the map and the
setcall. Nothing else changes.Tests
No test change. The removed map had no consumer, so behaviour is identical.
https://claude.ai/code/session_01W9Mk18mBNfkPfgg3hYweKq