Repository navigation
Conversation
no ref Use one initializer so synchronous subscriptions and asynchronous key checks share readiness and retry behavior. Keep job registration in its existing background phase, and undo partial IndexNow subscriptions when startup fails.
no ref Give runtime framework code a clear home alongside server and frontend. Move the initializer and its tests without changing behavior, document the boundary, and include the directory in lint and dependency checks.
no ref Keep kernel primitives independent of Ghost application code, including shared. Document the intended dependency direction and enforce it across the Ghost package.
no ref Keep the familiar .service access while guarding against use before initialization. Export the signing-keys wrapper intact so imports don't read the getter before boot, and update its callers and tests.
no ref Use the same service terminology as the rest of the initializer.
no ref Track adoption of the shared initializer separately from contract audits, with validated total and migrated counts. Refresh the first two migrated service records against their current implementation.
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 44s | View ↗ |
nx run ghost:test:ci:e2e |
✅ Succeeded | 5m 19s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 1m 38s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m 2s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 2m 55s | View ↗ |
nx run ghost:test:ci:unit |
✅ Succeeded | 1m 20s | View ↗ |
nx run-many -t test:unit -p ghost |
✅ Succeeded | 1m | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 18s | View ↗ |
Additional runs (6) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-10-10 07:22:19 UTC
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
WalkthroughAdds Suggested reviewers: Priority: ➖ Normal Change: Feature Merge Risk: ⚪ Minimal · up to No actionable issue remains from this review; the change is mergeable subject to normal checks. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly summarizes the main change: adding a shared initializer for IndexNow and signing keys. |
| Description check | |
The description directly explains the initializer, service readiness, retry behavior, rollback handling, inventory updates, and validation results. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Type-Safe Boundaries | |
The changed runtime code adds no unvalidated boundary-data consumption. defineService is a typed internal factory, and the IndexNow and signing-key changes only assemble existing dependencies, initi… |
| New Files Are Typescript | |
The pull request adds only ghost/core/kernel/README.md, ghost/core/kernel/define-service.ts, and ghost/test/unit/kernel/define-service.test.ts. It adds no .js, .jsx, .cjs, or .mjs files.… |
✨ Finishing Touches
-
📝 Generate docstrings
-
-
- Commit to this branch
- Create a new PR
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31701 +/- ##
==========================================
+ Coverage 81.40% 81.64% +0.23%
==========================================
Files 1653 1654 +1
Lines 60268 60273 +5
Branches 10544 10542 -2
==========================================
+ Hits 49064 49209 +145
+ Misses 9584 9464 -120
+ Partials 1620 1600 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Explain which startup guarantees belong to defineService and which cleanup belongs to its callback. Put the contract in developer guides and link it from the API comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start standardizing service initialization with IndexNow and signing keys. Both now use a small kernel helper that shares initialization, exposes the ready instance through
.service, and permits an explicit retry after failure. Boot owns when each service starts and awaits readiness.IndexNow rolls back partial event subscriptions if startup fails. Signing-key background scheduling keeps its existing owner. The inventory records 2 of 72 entries migrated and validates those counts.
Verification:
Passed:
pnpm test:typesfromghost.Passed:
pnpm exec vitest run test/unit/server/services/service-inventory.test.tsfromghost(74 tests).Passed: real Ghost boot on a fresh MySQL database; both instances ready, one IndexNow listener per event, staff/member key providers available, and both verification endpoints returning 200. Site and Admin also loaded in the browser.
Full validation is not clean locally.
NX_PARALLEL=1 pnpm checkpassed formatting, lint and the other workspace tests, but Core timed out in the unchanged jobs shutdown-deadline test. A retry exited with code 139.pnpm exec vitest run --maxWorkers=2then passed 9,760 tests and timed out in the unchanged gift-preview image test. Both affected files passed when run individually.I've read and followed the Contributor Guide
I've explained my change
I've written an automated test to prove my change works