Repository navigation
[3주차/서로] 워크북 제출합니다. - #32
Merged
Hidden character warning
The head ref may contain hidden characters: "\uc11c\ub85c/main"
Merged
Conversation
qkrdmsthff
reviewed
Oct 3, 2025
| )} | ||
|
|
||
| <div> | ||
| <DetailCard movie={movie} key={movie?.id} /> |
Member
There was a problem hiding this comment.
사소한 부분이긴 하지만 여기서 key={movie?.id} 를 전달하고 있는데요 ! key prop 은 배열을 렌더링할 때 각 항목을 구분하기 위해 사용하기 위한 거라, 단일 컴포넌트를 렌더링하는 현재 상황에서는 특별한 역할을 하지 않으므로 생략해도 괜찮을 것 같습니다 !! 이번 워크북도 고생 많으셨습니당 !!
using2
reviewed
Oct 3, 2025
Comment on lines
+13
to
+22
| {!actor.profile_path && ( | ||
| <img src={seoro} className="rounded-full size-20 object-cover"></img> | ||
| )} | ||
|
|
||
| {actor.profile_path && ( | ||
| <img | ||
| src={`https://image.tmdb.org/t/p/w92${actor.profile_path}`} | ||
| className="rounded-full size-20 object-cover border-2" | ||
| ></img> | ||
| )} |
There was a problem hiding this comment.
프로필 이미지 유무에 따라 분기해 렌더링하신 점이 명확하고 좋습니다!
여기서 3항 연산자로 src룰 조건부로 합치면, 중복이 줄어들어 가독성과 유지보수 측면에서 더 좋을 것 같아요.
또한 img에 alt를 배우 이름으로 추가하시면 접근성 면에서 더 좋을 것 같습니다.
예시:
<img
src={actor.profile_path ? `https://image.tmdb.org/t/p/w92${actor.profile_path}` : seoro}
alt={`${actor.name} 프로필 이미지`}
className="rounded-full size-20 object-cover border-2"}
/>
sunnyinha
reviewed
Oct 3, 2025
| } | ||
|
|
||
| .slide-Right { | ||
| animation: slideRight 1s ease-out forwards; |
Collaborator
There was a problem hiding this comment.
Tailwind 기본 유틸리티만으로는 한계가 있는데, 직접 keyframe을 정의해서 애니메이션을 적용하신 부분이 인상적이네요! 필요에 따라 tailwind.config.js 의 theme.extend.animation 사용하면 네이밍까지 Tailwind 스타일로 통합(.slide->animate-slideup(.없이 사용가능)) 할 수 있으니 참고해도 좋을 것 같아요!
sunnyinha
approved these changes
Oct 5, 2025
Collaborator
|
서로, 3주차도 수고하셨습니다! 머지해주세요~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트
📌 주안점