Repository navigation
[3주차/지니] 워크북 제출합니다. - #34
Merged
Merged
Conversation
pyopyojihun
reviewed
Oct 4, 2025
| export default function MoviesPage() { | ||
| const [movies, setMovies] = useState<Movie[]>([]); | ||
| const [loading, setLoading] = useState(true); | ||
| const [err, setErr] = useState<string | null>(null); |
There was a problem hiding this comment.
null 처리를 통해서 404와 콘솔에러 를 차단하신점이 인상적입니다!!
sunnyinha
reviewed
Oct 4, 2025
| @@ -0,0 +1 @@ | |||
| VITE_TMDB_TOKEN=eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiJlMDMzYmE1ZWE4NWJhN2E2Nzc1ODI1ZGY4OGJhNDkwMCIsIm5iZiI6MTc1OTM4Nzc2Mi4wNTksInN1YiI6IjY4ZGUyMDcyNTZlODIxMzkwZmZkMjEwNSIsInNjb3BlcyI6WyJhcGlfcmVhZCJdLCJ2ZXJzaW9uIjoxfQ.JVCyPuBdfRl0tIePXpbj1xyTGppUPQaOiv6vSM0yUyQ No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
API 키와 같은 민감한 정보는 보안상 소스코드에 직접 노출되면 위험합니다.
그래서 .env 파일은 절대 GitHub에 공개되면 안 되므로, chapter03/mission1/.gitignore에 .env를 꼭 추가해 gihub에는 올라오지 않고 로컬에서만 사용할 수 있도록 해주세요!
Comment on lines
+21
to
+28
| const title = useMemo(() => { | ||
| switch (kind) { | ||
| case "popular": return "인기 영화"; | ||
| case "now_playing": return "상영 중"; | ||
| case "top_rated": return "평점 높은"; | ||
| case "upcoming": return "개봉 예정"; | ||
| } | ||
| }, [kind]); |
sunnyinha
approved these changes
Oct 5, 2025
Collaborator
|
지니, 3주차도 수고하셨습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트
📌 주안점