MPC export: fit inside a safety-margin inset, not just the bare trim - #11
Open
unforcedagi wants to merge 2 commits into
Open
MPC export: fit inside a safety-margin inset, not just the bare trim#11unforcedagi wants to merge 2 commits into
unforcedagi wants to merge 2 commits into
Conversation
MakePlayingCards flagged an "uneven borders" preflight warning and put order 8C4D0D6B92857129BF1D3C3FC6735398 on hold. Our art is a true 2:3, narrower than MPC's 3.5x5" jumbo trim (0.70 ratio), so the export fit the art by height to the trim and padded the leftover width alone to reach it. That concentrated the whole aspect-ratio shortfall into the horizontal margin, leaving the vertical margin under MPC's own documented 1/8" safety-margin requirement (a second allowance inside the trim line, beyond bleed) on most cards once trimmed. Fit into a box already inset by that safety margin on every side instead, then fill out to the full upload canvas with the same edge-stretch bleed print_prep.py already uses safely. This holds regardless of how close any given card's own border sits to its own edge, which varies a lot between the Shell realm's ornate frame and the thinner Roots/Trunk/Branches line. Verified by simulating the actual trim cut and measuring where the flat stretched fill ends and real texture begins, on all 63 cards: 55/63 clear MPC's 37px safety threshold on all four sides outright, the remaining 8 are within 1-2px (rounding, not a structural gap) — down from every card failing it before on at least one side.
The safety-inset fix (previous commit) guaranteed every side cleared MPC's 37px minimum, but our art (2:3) is narrower than the inset box (0.684), so fitting by height alone left horizontal margin visibly larger than vertical. Cropping a thin, equal sliver off the top/bottom before fitting closes that gap. Verified on the deck's worst case (shell-08, 0px native cushion) with no visible mutilation, and confirmed live on order 160819266173 by downloading assigned files back and comparing against the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8C4D0D6B92857129BF1D3C3FC6735398and put it on hold.print_prep.pyalready uses safely. Works regardless of how close any given card's own border sits to its own edge (varies a lot between the Shell realm's ornate frame and the thinner Roots/Trunk/Branches line).Test plan
python3 tools/export_mpc.py— no errors, no missed corner marks.