Skip to content

MPC export: fit inside a safety-margin inset, not just the bare trim - #11

Open
unforcedagi wants to merge 2 commits into
Unforced-Dev:mainfrom
unforcedagi:mpc-safety-margin
Open

MPC export: fit inside a safety-margin inset, not just the bare trim#11
unforcedagi wants to merge 2 commits into
Unforced-Dev:mainfrom
unforcedagi:mpc-safety-margin

Conversation

@unforcedagi

Copy link
Copy Markdown
Contributor

Summary

  • MakePlayingCards flagged an "uneven borders" preflight warning on order 8C4D0D6B92857129BF1D3C3FC6735398 and put it on hold.
  • Root cause: our art is a true 2:3 ratio, narrower than MPC's 3.5x5" jumbo trim (0.70 ratio). The export fit art by height to the trim and padded only the leftover width to reach it — dumping the whole aspect-ratio shortfall into the horizontal margin, leaving vertical margin under MPC's own documented 1/8" safety-margin requirement (a second allowance inside the trim line, beyond bleed) on most cards once trimmed.
  • Fix: fit into a box already inset by that safety margin on every side, then fill out to the full upload canvas with the same edge-stretch bleed print_prep.py already uses safely. Works regardless of how close any given card's own border sits to its own edge (varies a lot between the Shell realm's ornate frame and the thinner Roots/Trunk/Branches line).

Test plan

  • Regenerated all 63 fronts + back via python3 tools/export_mpc.py — no errors, no missed corner marks.
  • Verified by simulating the actual trim cut and measuring where the flat stretched fill ends and real texture begins (not just "first dark pixel," which false-flagged cards whose border is black at their own true edge) — 55/63 cards clear MPC's 37px safety threshold on all four sides outright, the remaining 8 are within 1-2px (rounding, not structural).
  • Visually spot-checked both border styles (Shell realm's tight-margin ornate frame, Roots/Trunk/Branches' wider tan-margin line) plus a title/extra card — titles, rank medallions, and corner glyphs all composited correctly at the new canvas size.
  • Aaron to eyeball the two sample renders and approve before re-upload to the live MPC order.

MakePlayingCards flagged an "uneven borders" preflight warning and put order
8C4D0D6B92857129BF1D3C3FC6735398 on hold. Our art is a true 2:3, narrower
than MPC's 3.5x5" jumbo trim (0.70 ratio), so the export fit the art by
height to the trim and padded the leftover width alone to reach it. That
concentrated the whole aspect-ratio shortfall into the horizontal margin,
leaving the vertical margin under MPC's own documented 1/8" safety-margin
requirement (a second allowance inside the trim line, beyond bleed) on most
cards once trimmed.

Fit into a box already inset by that safety margin on every side instead,
then fill out to the full upload canvas with the same edge-stretch bleed
print_prep.py already uses safely. This holds regardless of how close any
given card's own border sits to its own edge, which varies a lot between
the Shell realm's ornate frame and the thinner Roots/Trunk/Branches line.

Verified by simulating the actual trim cut and measuring where the flat
stretched fill ends and real texture begins, on all 63 cards: 55/63 clear
MPC's 37px safety threshold on all four sides outright, the remaining 8 are
within 1-2px (rounding, not a structural gap) — down from every card
failing it before on at least one side.
The safety-inset fix (previous commit) guaranteed every side cleared MPC's
37px minimum, but our art (2:3) is narrower than the inset box (0.684), so
fitting by height alone left horizontal margin visibly larger than vertical.
Cropping a thin, equal sliver off the top/bottom before fitting closes that
gap. Verified on the deck's worst case (shell-08, 0px native cushion) with
no visible mutilation, and confirmed live on order 160819266173 by
downloading assigned files back and comparing against the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant