Skip to content

Wrong IR or JVM bytecode generation with empty try  #174

Open

Description

@DaniilStepanov

Example:

    var lambda: (() -> String)? = null

    fun f() {
        try {
        } finally {
            lambda = { "OK" }
        }
    }
    @JvmStatic
    fun box(): String {
        f()
        return lambda?.let { it() } ?: "fail"
    }

Activity

  1. DaniilStepanov commented on Sep 8, 2023

    @DaniilStepanov
    CollaboratorAuthor

    One more test for try/catch/finally:

    fun test1() : String {
        var s = "";
        try {
            try {
                s += "Try";
                throw Exception()
            } catch (x : Exception) {
                s += "Catch";
                throw x
            } finally {
                s += "Finally";
            }
        } catch (x : Exception) {
            return s
        }
    }
    
    fun test2() : String {
        var s = "";
    
        try {
            s += "Try";
            throw Exception()
        } catch (x : Exception) {
            s += "Catch";
        } finally {
            s += "Finally";
        }
    
        return s
    }
    
    
    
    fun box() : String {
        if (test1() != "TryCatchFinally") return "fail1: ${test1()}"
    
        if (test2() != "TryCatchFinally") return "fail2: ${test2()}"
    
        return "OK"
    }
  2. DaniilStepanov commented on Sep 8, 2023

    @DaniilStepanov
    CollaboratorAuthor

    More:

    fun unsupportedEx() {
        if (true) throw UnsupportedOperationException()
    }
    
    fun runtimeEx() {
        if (true) throw RuntimeException()
    }
    
    fun test1WithFinally() : String {
        var s = "";
        try {
            try {
                s += "Try";
                unsupportedEx()
            } finally {
                s += "Finally"
            }
        } catch (x : RuntimeException) {
            return s
        }
        return s + "Failed"
    }
    
    
    fun test2WithFinally() : String {
        var s = "";
        try {
            try {
                s += "Try";
                unsupportedEx()
                return s
            } finally {
                s += "Finally"
            }
        } catch (x : RuntimeException) {
            return s
        }
    }
    
    fun box() : String {
        if (test1WithFinally() != "TryFinally") return "fail2: ${test1WithFinally()}"
    
        if (test2WithFinally() != "TryFinally") return "fail4: ${test2WithFinally()}"
        return "OK"
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingir

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions