Repository navigation
[TS] Execute default export expressions during module initialization - #394
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
export default <expression>in source order in the module%dfltmethod.defaultfield and point export metadata to that snapshot, so later writes to the source variable do not change the default export.Fixes #378.
Checks
npm run typechecknpm test(218 TypeScript frontend tests)EtsTsFrontendTestfor bundled frontend JSON deserialization and model conversionEtsExportTest(8 tests)checkLicensepre-commit hookThe regression compares the sample's result with TypeScript's CommonJS output in Node (
default === 1,after === 10), and separately checks the corresponding EtsIR call, assignment, and source order. The Kotlin integration test checks the production JSON path. No EtsIR runtime execution is claimed.