Repository navigation
[#146] Disable EOL conversion for TestCommon/Data - #155
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #146.
Unity data files under
TestCommon/Datawere only partly covered by thebinaryrules in.gitattributes.Anything else fell through to
* text=auto eol=lf, where git decides by looking for a NUL byte in the first8000 bytes. Some files, such as
sharedassets0.assets.resS, were classified as text. Nothing is corrupttoday, but a future fixture containing
0d 0awould have it rewritten on checkout.Changes
TestCommon/Data/** -textturns off EOL conversion for the whole test data folder. A path rule is usedrather than per-extension
binaryrules because many fixtures have no extension (bundle names likealienprefab,a,6,CAB-*).TestCommon/Data/**/*.md textkeeps the README/AGENTS/CLAUDE files normalized.-text(notbinary) is used so the JSON, manifest and txt fixtures still show text diffs.Testing
git add --renormalize .produced no content changes to any committed file.git check-attrconfirms.resSis nowtext: unsetand the READMEs aretext: set.dotnet test: full suite green.🤖 Generated with Claude Code