Skip to content

[#146] Disable EOL conversion for TestCommon/Data - #155

Merged
SkowronskiAndrew merged 1 commit into
mainfrom
issue146-gitattributes-binary-data
Nov 3, 2026
Merged

SkowronskiAndrew merged 1 commit into
mainfrom
issue146-gitattributes-binary-data

Conversation

@SkowronskiAndrew

Copy link
Copy Markdown
Collaborator

Summary

Fixes #146.

Unity data files under TestCommon/Data were only partly covered by the binary rules in .gitattributes.
Anything else fell through to * text=auto eol=lf, where git decides by looking for a NUL byte in the first
8000 bytes. Some files, such as sharedassets0.assets.resS, were classified as text. Nothing is corrupt
today, but a future fixture containing 0d 0a would have it rewritten on checkout.

Changes

  • TestCommon/Data/** -text turns off EOL conversion for the whole test data folder. A path rule is used
    rather than per-extension binary rules because many fixtures have no extension (bundle names like
    alienprefab, a, 6, CAB-*).
  • TestCommon/Data/**/*.md text keeps the README/AGENTS/CLAUDE files normalized.
  • -text (not binary) is used so the JSON, manifest and txt fixtures still show text diffs.

Testing

  • git add --renormalize . produced no content changes to any committed file.
  • git check-attr confirms .resS is now text: unset and the READMEs are text: set.
  • dotnet test: full suite green.

🤖 Generated with Claude Code

@SkowronskiAndrew
SkowronskiAndrew merged commit 97c45ab into main Nov 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Binary test data is not fully covered by .gitattributes and can be mangled by EOL conversion

1 participant