Distinguish failing vs stale review verdicts in check summary output - #7
Merged
Merged
Conversation
Collaborator
|
@copilot instead of
|
Copilot
AI
changed the title
[WIP] Fix check summary labels failing review verdicts as stale reviews
Distinguish failing vs stale review verdicts in Jul 29, 2026
check summary output
sansari
marked this pull request as ready for review
July 29, 2026 20:56
sansari
approved these changes
Jul 29, 2026
Copilot stopped work on behalf of
sansari due to an error
July 29, 2026 20:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npx rfc2119 checkcorrectly emitted per-verdict diagnostics for failing reviews, but the final summary bucketed those failures asstale review(s), obscuring the required next action. This change separates failing verdicts from stale/missing verdicts in the summary line.Summary classification update (
src/cli.ts)report.staleReviews.lengthwith explicit rule-based counts fromreport.violations:REQ-003.2.4→failing review(s)REQ-003.3.1→stale review(s)Focused CLI behavior coverage (
tests/cli.test.ts)failverdict and asserts summary output reports:1 failing review(s), 0 stale review(s)