Skip to content

Distinguish failing vs stale review verdicts in check summary output - #7

Merged
sansari merged 2 commits into
mainfrom
copilot/check-summary-labels-stale-reviews
Jul 29, 2026
Merged

Distinguish failing vs stale review verdicts in check summary output#7
sansari merged 2 commits into
mainfrom
copilot/check-summary-labels-stale-reviews

Conversation

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

npx rfc2119 check correctly emitted per-verdict diagnostics for failing reviews, but the final summary bucketed those failures as stale review(s), obscuring the required next action. This change separates failing verdicts from stale/missing verdicts in the summary line.

  • Summary classification update (src/cli.ts)

    • Replaced summary use of report.staleReviews.length with explicit rule-based counts from report.violations:
      • REQ-003.2.4failing review(s)
      • REQ-003.3.1stale review(s)
    • Keeps total violation/uncovered counts unchanged while making review status actionable.
  • Focused CLI behavior coverage (tests/cli.test.ts)

    • Added an end-to-end case that records a fail verdict and asserts summary output reports:
      • 1 failing review(s), 0 stale review(s)
const failingReviewCount = report.violations.filter((v) => v.rule === "REQ-003.2.4").length;
const staleReviewCount = report.violations.filter((v) => v.rule === "REQ-003.3.1").length;

@sansari

sansari commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

@copilot instead of check: FAIL — 29 violation(s), 23 uncovered, 6 review failure(s), 0 stale review(s) make it like this:

check: FAILED w/ 29 violation(s) — 23 uncovered, 6 review failure(s), 0 stale review(s)

Copilot AI changed the title [WIP] Fix check summary labels failing review verdicts as stale reviews Distinguish failing vs stale review verdicts in check summary output Jul 29, 2026
Copilot AI requested a review from sansari July 29, 2026 20:55
@sansari
sansari marked this pull request as ready for review July 29, 2026 20:56
@sansari
sansari merged commit b06de1d into main Jul 29, 2026
1 of 2 checks passed
Copilot stopped work on behalf of sansari due to an error July 29, 2026 20:57
Copilot AI requested a review from sansari July 29, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check summary labels failing review verdicts as stale reviews

2 participants