Introduce Windows CI - #605
Draft
Krzmbrzl wants to merge 31 commits into
Draft
Conversation
Krzmbrzl
force-pushed
the
windows-ci
branch
2 times, most recently
from
September 3, 2026 09:21
f089dd5 to
5d616dd
Compare
Krzmbrzl
force-pushed
the
windows-ci
branch
2 times, most recently
from
September 3, 2026 10:03
c43c0e0 to
a0e4fea
Compare
We now use the library in a way that is not specific to the FetchContent way we obtain it. Instead, we now use canonical include paths, without requiring the overly generic "utf8.h" include.
With older versions an MSVC bug/issue causes compile errors
Krzmbrzl
commented
Sep 3, 2026
Krzmbrzl
force-pushed
the
windows-ci
branch
2 times, most recently
from
September 3, 2026 13:51
aa1def8 to
3074c06
Compare
Krzmbrzl
force-pushed
the
windows-ci
branch
3 times, most recently
from
September 3, 2026 15:58
77ee703 to
5f90499
Compare
Krzmbrzl
force-pushed
the
windows-ci
branch
9 times, most recently
from
September 4, 2026 11:30
0fdcb3b to
352c0f5
Compare
They already were but only via a default argument in an explicit constructor. That confuses MSVC.
Instead, we make it so that we only evaluate it at template instantiation at which point the CRTP parameter class has been fully defined. If we do the evaluation at template definition, the CRTP class is not yet fully defined and we might get a compiler error (MSVC).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.