Skip to content

Allow custom converters to override built-in converters - #1910

Merged
SimonCropp merged 1 commit into
VerifyTests:mainfrom
shubmittal:fix-converter-priority-1834
Sep 19, 2026
Merged

Allow custom converters to override built-in converters#1910
SimonCropp merged 1 commit into
VerifyTests:mainfrom
shubmittal:fix-converter-priority-1834

Conversation

@shubmittal

@shubmittal shubmittal commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Give converters added through AddExtraSettings priority over Verify's built-in converters.
  • Preserve custom converter order when settings are changed or copied.
  • Add tests for overriding, ordering, insertion, and removal.

Fixes #1834

Validation

  • 4 focused tests passed.
  • Verify.Tests on .NET 11: 1,362 total, 0 failed.
  • Release solution build passed.

Shubhra Mittal
Fix converter priority for extra settings
8e1e945 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@shubmittal

shubmittal commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@SimonCropp SimonCropp added this to the 33.1.0 milestone Sep 19, 2026
@SimonCropp
SimonCropp merged commit d96ed69 into VerifyTests:main Sep 19, 2026
4 checks passed
@SimonCropp

SimonCropp commented Sep 19, 2026

Copy link
Copy Markdown
Member

thanks for this

This was referenced Sep 19, 2026
Open
Merged
Open
Closed
Open
Closed
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

33.1.0

Development

Successfully merging this pull request may close these issues.

Converters from AddExtraSettings cannot override built-in converters

2 participants

@shubmittal @SimonCropp