Don't send legacy clients their own death event#1296
Merged
kennytv merged 1 commit intoJul 18, 2026
Conversation
Clients up to 1.13.2 run the local death handling on their own entity death event, clearing their own inventory client-side (most visibly an emptied hotbar on the death screen, since modern servers don't resync the inventory on death). The death screen still shows from the health update. 1.14+ clients no longer clear the inventory.
Term4
force-pushed
the
fix/legacy-death-inventory-clear
branch
from
July 17, 2026 15:43
9d4f902 to
939226c
Compare
kennytv
approved these changes
Jul 18, 2026
Contributor
Author
|
I actually want to go back and check something beanes brought to me, that we need to ensure that a corresponding update health packet is sent so the client properly handles its own death. For a case in which a modern server sends a death event directly without updating health, should that occur with plugins or what have you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients up to 1.13.2 run the local death handling on their own entity death event, clearing their own inventory client-side (most visibly an emptied hotbar on the death screen, since modern servers don't resync the inventory on death). The death screen still shows from the health update. 1.14+ clients no longer clear the inventory.