Fix splash potions turning into drinkable potions when re-sent by the…#703
Merged
Conversation
… client The 1.9->1.8 serverbound item conversion only restored the splash potion id (373 -> 438) when no Potion tag was present, but the clientbound conversion keeps that tag on the item. A creative mode client re-sending its inventory (e.g. on inventory close) therefore turned every splash potion into a drinkable one.
# Conflicts: # common/src/main/java/com/viaversion/viarewind/protocol/v1_9to1_8/storage/EntityTracker1_9.java
florianreuth
approved these changes
Jul 25, 2026
florianreuth
left a comment
florianreuth
left a comment
Member
There was a problem hiding this comment.
Seems like the code still has edge cases (not related to the PR), thank you!
Contributor
Author
|
It does. I've seen people having issues with them in 1.7, so I'll be trying to fix that soon(ish). I have an issue with my network which basically makes it impossible to join even local servers on 1.7 tho unfortunately. |
|
is there a related issue/PR up about potions being affected by the client when they are in creative mode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.9->1.8 serverbound item conversion only restored the splash potion id (373 -> 438) when no Potion tag was present