fix(mobile): show the renamed session name on Android cross-device cards - #326
Merged
Merged
Conversation
The mobile "Live on other devices" strip still printed connectionName, so a renamed tab was indistinguishable there while the desktop card already showed its title. Both now go through sessionLabel instead of keeping a second copy of the title-or-connection fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mobile "Live on other devices" strip still printed
connectionName, so on Android a renamed tab could not be told apart from any other session on the same host. The desktop card already showed the title (6dee8cf).Both now call
sessionLabel()instead of keeping a second copy of the title-or-connection fallback:RemoteDeviceSessions.tsx— the twoa.title || a.connectionNamespotsMobileRemoteDeviceSessions.tsx— the card labelMobileRemoteDeviceSessions.test.tsxcovering both the renamed title and the connection-name fallbacktsc --noEmitclean; the three affected test files pass. Not yet exercised on a device — the strip only renders with a live manifest published from another device.