Repository navigation
Conversation
…, bump c# 7.3 -> 8
~ 0.9% speed improvement in heapsort bench, allocations reduced too
Contributor
|
Four things.
|
Member
Author
|
I agree with 1-3, will edit and split the PR accordingly. |
Member
Author
|
Zero-indexed tables extracted to #4 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option on Script config level to index tables from zero. The option itself is implemented as
intas it simplifies access (compared toboolimpl). I've stated that values other than 1 & 0 are not working but we might as well throw on set if an user attempts to set the value to something else. The setting is set to 1 by default hence this is a nonbreaking change.Some table operations have been slightly optimized. In particular I've refactored & inlined slow
GetIntegralKeymethod.If-elsenesting was reduced in several places and extraneous statements such aselseafterreturnin the branch directly above removed.Opinionated helper property
DynValue.Inthas been added. I'm open to replace that with a better name. It's just a shorthand for(int)DynValue.Numberwhich we are using all over the place.A few overloads have been added to the
Table. This is mostly to get consistent overloads for various functions. I intend to make a few more of these later.I've included a new mechanism for loading test cases as the old one requires a line of manual code to be added for every new test. I can refactor old tests to be loaded in this way too.
The structure of a new test is as follows:
Further commits included:
CallStackItemrefactored to struct