Repository navigation
retire v0 (1/2): delete the retained v0 binding code and prune its protected paths (#431) - #470
Merged
Merged
Conversation
…d paths (#431) Approved by the maintainer (public issue #431). - delete the five Go v0 verification files, Python's fetch.py and _manifest.py, TS's fetch.ts, Rust's dead src/fetch/ and digest.rs, and tests/parity/manifest.json - policy-merge-check: drop their PROTECTED_GLOBS entries; the registry adapters' reasons describe v1; the docstring and the carve-out selftest use the v1 tree - CONTRIBUTING.md: the generated protected-glob block, and the carve-out prose - drop the build exclusions for the deleted files (pyproject, tsconfig x2, biome) - comments that cited the deleted files point at the v1 code; regenerated (gen-constants --write, abi-v1 gen --write; the ABI fingerprint is unchanged) - v1-abi-gen: check-no-hand-decls --scope all (0 findings over 221 files) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The comment fix in genfixtures/sign.go (it cited a deleted v0 file) changes the generator's recorded identity; every fixture file is otherwise byte-identical. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
EricAndrechek
marked this pull request as ready for review
October 6, 2026 11:58
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retire the v0 binding code (part 1 of #431, approved by the maintainer). The second part, the v0 channel tooling, follows in its own pull request. Both land before
v1merges intomain.Deleted:
fetch_sign.go,fetch.go,registry_path.go,multiversion.go,resolve.go).fetch.pyand_manifest.py, which nothing imported.ts/src/fetch.ts, already excluded from the build.src/fetch/anddigest.rs, which no module declared.tests/parity/manifest.json, which nothing read.The security checker (
scripts/policy-merge-check.py):PROTECTED_GLOBSentries are removed. The three registry adapters' entries stay, with reasons that describe the v1 code._ed25519.pyandrust/src/ocifetch/**.--check-carve-outcovers 59 files, all in the four fetch layers,_ed25519.pyand the three registry adapters.CONTRIBUTING.md: the protected-glob block is regenerated from the checker, and the carve-out prose describes v1.Also:
python/pyproject.toml,ts/tsconfig.json,ts/tsconfig.test.json,ts/biome.json).v1-abi-gennow runscheck-no-hand-decls.py --scope all: 0 findings over 221 files.Checked locally, all exit 0:
policy-merge-check.py --selftest,--check-carve-outand--check-guide;check-selftests-wired,lint-public,lint-spelling,lint-cited-paths,lint-actions;gen-constants --check,abi-v1/gen.py --check;go vetandgo test ./...,go mod tidy -diff(clean, no-e),uv run pytest -q,cargo check --locked --all-targets, and bothtsc --noEmitconfigs.Refs #431.
🤖 Generated with Claude Code