Skip to content

Feature/about us first section#107

Merged
cherylli merged 18 commits into
masterfrom
feature/about-us-first-section
Jun 22, 2022
Merged

Feature/about us first section#107
cherylli merged 18 commits into
masterfrom
feature/about-us-first-section

Conversation

@cherylli

@cherylli cherylli commented Jun 8, 2022

Copy link
Copy Markdown
Member
Web Dev Path
106

Have you updated the CHANGELOG.md file? If not, please do it.

yes

What is this change?

  1. Add about content and styling (for first section)
  2. Restructure components folder
  3. Change relative to absolute import

Were there any complications while making this change?

no

How did you verify this change?

Run locally in mobile and desktop mode in different screen sizes

When should this be merged?

After review

@cherylli cherylli self-assigned this Jun 8, 2022
@netlify

netlify Bot commented Jun 8, 2022

Copy link
Copy Markdown

Deploy Preview for priceless-booth-2dfcaf ready!

Name Link
🔨 Latest commit 7a21c2d
🔍 Latest deploy log https://app.netlify.com/sites/priceless-booth-2dfcaf/deploys/62b145f159d1a20008453fe2
😎 Deploy Preview https://deploy-preview-107--priceless-booth-2dfcaf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cherylli

cherylli commented Jun 8, 2022

Copy link
Copy Markdown
Member Author

mostly done waiting for new image.


new component structure, open to suggestions

@cherylli cherylli linked an issue Jun 8, 2022 that may be closed by this pull request
Comment thread CHANGELOG.md
@cherylli

Copy link
Copy Markdown
Member Author

Not sure if there's already a mobile design. Can't find it on figma, so just using the default TwoColumn mobile view.

@cherylli cherylli marked this pull request as ready for review June 15, 2022 14:33
@cherylli cherylli requested a review from mariana-caldas June 15, 2022 14:34

@mariana-caldas mariana-caldas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new file structure makes so much sense, @cherylli ! Thanks so much, you rock! 🚀
I just see some minor adjustments. Feel free to reach out if you have questions about them.
Could you please request my review again whenever it is ready?

Comment thread .gitignore
Comment thread styles/Title.module.scss Outdated
Comment thread styles/globals.scss Outdated
@cherylli cherylli requested a review from mariana-caldas June 16, 2022 01:08
@cherylli cherylli dismissed mariana-caldas’s stale review June 16, 2022 05:33

Just saw a spelling mistake

@cherylli cherylli marked this pull request as draft June 18, 2022 01:16
@cherylli cherylli marked this pull request as ready for review June 18, 2022 06:14

@wenebob wenebob left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The First section looks great! Everything seems to be on point. However, concerning the mobile view, I want to suggest that under the 'About Web Dev Path' heading the images should come before the paragraph rather than after. Great job

@cherylli

cherylli commented Jun 18, 2022

Copy link
Copy Markdown
Member Author

The First section looks great! Everything seems to be on point. However, concerning the mobile view, I want to suggest that under the 'About Web Dev Path' heading the images should come before the paragraph rather than after. Great job

Thanks. As mentioned above there's no official mobile design yet. so this might be a suggestion to the @Web-Dev-Path/designers team.

@camille-granier camille-granier left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mariana-caldas mariana-caldas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path organization is amazing, @cherylli ! Such a great job! Could you pls just make the Github and Bitbucket links and connect them to their respective pages?

https://github.com/
https://bitbucket.org/product/

@cherylli cherylli requested a review from mariana-caldas June 20, 2022 03:38

@mariana-caldas mariana-caldas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! "Habemus" first section, @cherylli ! Great job! 🥇
Can you just wait until Wednesday to merge it so we give some time for more reviews?

@cherylli

Copy link
Copy Markdown
Member Author

Should we set up a project specific file like prettier or eslint for formatting consistency? I normally use single quotes for most things in js so my auto formatter might have done that.

@mariana-caldas

Copy link
Copy Markdown
Member

Should we set up a project specific file like prettier or eslint for formatting consistency? I normally use single quotes for most things in js so my auto formatter might have done that.

You're absolutely right! We actually added .prettier already (#69), I may have deactivated it locally somehow and need to figure out why it stopped working on my end.

@cherylli cherylli merged commit 4daf753 into master Jun 22, 2022
@cherylli cherylli deleted the feature/about-us-first-section branch June 22, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add About Us page first section

4 participants