Repository navigation
Always use LaneResults for SIMD values in spec tests - #8434
Merged
Merged
Conversation
stevenfontanella
changed the title
stevenfontanella
force-pushed
the
lanes
branch
3 times, most recently
from
March 9, 2026 21:37
f1137b9 to
bed56b7
Compare
stevenfontanella
changed the title
stevenfontanella
changed the title
stevenfontanella
marked this pull request as ready for review
March 9, 2026 22:14
tlively
reviewed
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For use in #8421. Previously LaneResults was only used if the expected v128 constant contained NaN patterns, which meant that we lose the shape information (otherwise they were stored/matched as a normal v128 Literal). Change the parser to always use LaneResult so that we keep the shape information and can output exactly which lane doesn't match during test failures.
Error message before:
Error message after:
Part of #8261 and #8315.