Implement Windows-specific readonly file handling in file I/O error tests

[coderabbitai]

Description

The Windows-specific code block in the readonly file test is currently empty, which means the test doesn't properly validate readonly file behavior on Windows platforms.

Location

• File: tests/file_io_error_handling_test.rs
• Lines: 124-126
• Test: test_write_to_readonly_file_error

Problem

The current implementation has an empty #[cfg(windows)] block, so the readonly file test only works on Unix systems. Windows requires different API calls to set file attributes as read-only.

Expected Implementation

The Windows branch should:

1. Create and write initial content to the test file
2. Set the FILE_ATTRIBUTE_READONLY flag using Windows API (SetFileAttributesW or helper crate)
3. Run the same readonly behavior assertions as the Unix path
4. Clear the read-only attribute before cleanup to ensure successful file deletion

References

• Original PR: Enhances file I/O & adds security policy #150
• Code review comment: Enhances file I/O & adds security policy #150 (comment)

Requested by

@logbie

[logbie]

@claude investigate this issue and fix if necessary

[claude]

Claude finished @logbie's task —— View job • claude/issue-151-20250812-1740 • Create PR ➔

---

Windows readonly file handling implementation completed ✅

Successfully implemented the missing Windows-specific readonly file handling in the debug report tests.

Todo List:

• Read repository guidelines (CLAUDE.md)
• Examine current test file structure
• Write a failing Windows test to reproduce current behavior (currently just prints skip message)
• Implement Windows-specific readonly file handling using Windows APIs
• Build and test the changes to ensure Windows test passes
• Commit and push changes following TDD workflow
• Provide PR creation link

Summary of Changes:

• Fixed the actual issue: The test was in src/debug_report.rs (lines 388-393), not the path mentioned in the issue description
• Implemented Windows-specific readonly handling: Used Windows API SetFileAttributesW with FILE_ATTRIBUTE_READONLY flag
• Matched Unix test behavior: Creates temp directory, sets readonly, tests create_report() failure, then cleans up
• Added proper cleanup: Removes readonly attribute before directory deletion to prevent cleanup failures
• Fixed code quality: Resolved all clippy warnings for uninlined format args

Technical Details:
The Windows implementation uses std::os::windows::fs::MetadataExt and direct Windows API calls to:

1. Set FILE_ATTRIBUTE_READONLY on the test directory
2. Verify that create_report() correctly fails when attempting to write to a readonly location
3. Clean up by removing the readonly attribute for successful directory deletion

All tests pass and the implementation follows the project's TDD principles and coding standards.

---