Skip to content

Documentation: Conflicting security guidance for subprocess execution #188

Description

@coderabbitai

Description

The subprocess execution documentation in Docs/wfldocs/WFL-io.md contains conflicting guidance about whether execute command "echo Hello World" runs via shell or direct execution.

Contradiction Details

  • Lines 517-521 (Safe Execution section): Label execute command "echo Hello World" as SAFE direct execution without shell
  • Lines 421-425 (Cross-Platform Execution section): Show the same command working cross-platform via shell (cmd.exe on Windows, sh on Unix)

This creates confusion about:

  1. Whether this command invokes a shell or runs directly
  2. Whether it's safe from injection attacks by default
  3. How WFL resolves simple commands like "echo"

Location

  • File: Docs/wfldocs/WFL-io.md
  • Lines: ~421-425 and ~517-521

Context

This issue was identified during code review of PR #185 which adds subprocess execution features.

Related Links

Reported by: @logbie

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentation

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions