Skip to content

Refactor stdlib argument validation helpers #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logbie merged 6 commits into from
Feb 4, 2026
Merged

Refactor stdlib argument validation helpers #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d8a5faa
refactor: consolidate stdlib type checking logic into helpers
google-labs-jules[bot] Feb 3, 2026
b406937
refactor: consolidate stdlib type checking and fix validation bugs
google-labs-jules[bot] Feb 3, 2026
e453c08
Merge branch 'main' into refactor-stdlib-helpers-5322279996455786309
logbie Feb 4, 2026
ee3f19e
Merge branch 'main' into refactor-stdlib-helpers-5322279996455786309
logbie Feb 4, 2026
919be32
Remove ad-hoc verify_fix.rs and create proper integration test
logbie Feb 4, 2026
65ba45d
Docs: Add comprehensive documentation for stdlib helpers
logbie Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .claude/settings.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@
"mcp__ide__getDiagnostics",
"Bash(..targetreleasewfl.exe nexus.wfl)",
"Bash(gh pr view:*)",
"Bash(git merge:*)"
"Bash(git merge:*)",
"Bash(git push:*)",
"Bash(gh pr checkout:*)",
"Bash(git pull:*)"
],
"deny": [],
"ask": []
Expand Down
49 changes: 14 additions & 35 deletions src/stdlib/crypto.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,44 +421,30 @@ pub fn native_wflhash256(args: Vec<Value>) -> Result<Value, RuntimeError> {
check_arg_count("wflhash256", &args, 1)?;

let text = expect_text(&args[0])?;
let input = text.as_bytes();

let params = WflHashParams::new(32); // 256 bits = 32 bytes
let hash_bytes = wflhash_core_text(input, &params)?; // Validate UTF-8 for text
let hash_hex = bytes_to_hex(&hash_bytes);

Ok(Value::Text(Rc::from(hash_hex)))
let hash = wflhash_core_text(text.as_bytes(), &params)?;
Ok(Value::Text(Rc::from(bytes_to_hex(&hash))))
}

/// WFLHASH-512 implementation with security fixes
pub fn native_wflhash512(args: Vec<Value>) -> Result<Value, RuntimeError> {
check_arg_count("wflhash512", &args, 1)?;

let text = expect_text(&args[0])?;
let input = text.as_bytes();

let params = WflHashParams::new(64); // 512 bits = 64 bytes
let hash_bytes = wflhash_core_text(input, &params)?; // Validate UTF-8 for text
let hash_hex = bytes_to_hex(&hash_bytes);

Ok(Value::Text(Rc::from(hash_hex)))
let hash = wflhash_core_text(text.as_bytes(), &params)?;
Ok(Value::Text(Rc::from(bytes_to_hex(&hash))))
}

/// WFLHASH-256 with personalization/salt support
pub fn native_wflhash256_with_salt(args: Vec<Value>) -> Result<Value, RuntimeError> {
check_arg_count("wflhash256_with_salt", &args, 2)?;

let text = expect_text(&args[0])?;
let input = text.as_bytes();

let salt_text = expect_text(&args[1])?;
let salt = salt_text.as_bytes();

let params = WflHashParams::new_with_personalization(32, salt);
let hash_bytes = wflhash_core_text(input, &params)?;
let hash_hex = bytes_to_hex(&hash_bytes);

Ok(Value::Text(Rc::from(hash_hex)))
let salt = expect_text(&args[1])?;
let params = WflHashParams::new_with_personalization(32, salt.as_bytes());
let hash = wflhash_core_text(text.as_bytes(), &params)?;
Ok(Value::Text(Rc::from(bytes_to_hex(&hash))))
}

/// WFLHASH-256 with key for MAC functionality (WFLMAC-256)
Expand All @@ -467,24 +453,17 @@ pub fn native_wflmac256(args: Vec<Value>) -> Result<Value, RuntimeError> {
check_arg_count("wflmac256", &args, 2)?;

let text = expect_text(&args[0])?;
let input = text.as_bytes();

let key_text = expect_text(&args[1])?;
let key = key_text.as_bytes();

// Use proper key derivation with error handling
let params = WflHashParams::new_with_key(32, key)?;
let hash_bytes = wflhash_core_text(input, &params)?;
let hash_hex = bytes_to_hex(&hash_bytes);

Ok(Value::Text(Rc::from(hash_hex)))
let key = expect_text(&args[1])?;
let params = WflHashParams::new_with_key(32, key.as_bytes())?;
let hash = wflhash_core_text(text.as_bytes(), &params)?;
Ok(Value::Text(Rc::from(bytes_to_hex(&hash))))
}

/// WFLHASH-256 for binary data (no UTF-8 validation)
pub fn native_wflhash256_binary(data: &[u8]) -> Result<String, RuntimeError> {
let params = WflHashParams::new(32); // 256 bits = 32 bytes
let hash_bytes = wflhash_core(data, &params)?;
Ok(bytes_to_hex(&hash_bytes))
let hash = wflhash_core(data, &params)?;
Ok(bytes_to_hex(&hash))
}

/// Constant-time MAC verification using subtle crate
Expand Down
Loading