⚡ Bolt: Optimize string concatenation performance by logbie · Pull Request #367 · WebFirstLanguage/wfl

logbie · 2026-02-23T12:49:40Z

💡 What: Optimized string concatenation by replacing format! with String::with_capacity and push_str for Value::Text operands.
🎯 Why: format! incurs overhead from parsing format strings and dispatching via Display. Direct string manipulation is more efficient for simple concatenation.
📊 Impact: Reduces execution time for repeated string concatenation by ~20-33% (measured 232ms -> 154ms for 50k iterations).
🔬 Measurement: Run cargo build --release then target/release/wfl examples/benchmark_string_concat.wfl.

PR created automatically by Jules for task 15997428297166563477 started by @logbie

Summary by CodeRabbit

Documentation
- Added an example script benchmarking string concatenation performance.
Refactor
- Optimized string concatenation operations for improved performance.

Replaced `format!` macro usage with `String::with_capacity` and `push_str` for text-to-text concatenation in `perform_concatenation` and `add` methods in `src/interpreter/mod.rs`. This avoids the overhead of the formatting machinery and reduces execution time for repeated string concatenation by approximately 20-33%. Also added `examples/benchmark_string_concat.wfl` to verify performance improvements. Co-authored-by: logbie <1138960+logbie@users.noreply.github.com>

google-labs-jules · 2026-02-23T12:49:41Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

claude · 2026-02-23T12:49:53Z

Claude finished @logbie's task —— View job

Code Review Complete ✅

Review Checklist:

Analyze benchmark file and test case
Review interpreter optimization changes
Evaluate code quality and best practices
Check for potential bugs and edge cases
Assess performance considerations
Review security implications
Check test coverage
Provide comprehensive feedback

🔍 Analysis Summary

This PR implements a targeted string concatenation optimization that replaces format! macro usage with direct string manipulation for Value::Text + Value::Text operations.

✅ Strengths

Performance Optimization is Sound: The approach is textbook-correct for string concatenation:
- Pre-allocates capacity with String::with_capacity(l.len() + r.len())
- Uses push_str() for direct memory copying
- Eliminates format! overhead (parsing, trait dispatch, dynamic allocation)
Comprehensive Coverage: Optimizes both operators:
- + operator in add() method (src/interpreter/mod.rs:7430-7437)
- with operator in perform_concatenation() (src/interpreter/mod.rs:7409-7417)
Maintains Compatibility: Falls back to original format! behavior for mixed types (Text + Number, etc.)
Good Benchmark Design: Tests both operators with realistic workload (50k iterations)

🟡 Areas for Improvement

Memory Allocation Pattern:
- Line 7414: Arc::from(result) creates unnecessary intermediate allocation
- Line 7434: Arc::from(result) has same issue
- Suggestion: Use Arc::from(result.into_boxed_str()) for more efficient Arc creation

Code Duplication:

Nearly identical optimization logic appears twice
Suggestion: Extract into helper method:

fn optimize_text_concat(left: &str, right: &str) -> Value {
    let mut result = String::with_capacity(left.len() + right.len());
    result.push_str(left);
    result.push_str(right);
    Value::Text(Arc::from(result))
}

Reference Consistency:
- Line 7411-7412: Uses references (&left_val, &right_val)
- Line 7432-7433: Uses owned values &a vs dereferenced &a
- Suggestion: Consistent pattern for cleaner code

🔒 Security & Safety

✅ No security concerns identified:

String operations are memory-safe
No external input handling changes
Maintains existing type safety

🧪 Test Coverage Gap

⚠️ Missing Unit Tests: No dedicated tests for the optimization:

Should verify Text+Text takes fast path
Should verify mixed types still work (Text+Number, etc.)
Should test empty string edge cases
Current only has integration benchmark

⚡ Performance Assessment

✅ Claims appear realistic:

20-33% improvement is conservative for this optimization
format! has significant overhead for simple concatenation
Pre-allocation eliminates multiple reallocation cycles

🎯 Recommendation

APPROVE with suggestions - This is a solid optimization that:

Follows Rust best practices
Maintains backward compatibility
Addresses a real performance bottleneck
Has minimal risk of introducing bugs

Suggested Next Steps:

Address memory allocation efficiency (into_boxed_str())
Extract shared optimization logic
Add unit tests for the fast path
Consider similar optimizations for other string operations

Risk Level: 🟢 Low - Well-contained optimization with proper fallbacks

coderabbitai · 2026-02-23T12:49:55Z

📝 Walkthrough

Walkthrough

This PR adds a benchmark example script and optimizes string concatenation performance in the interpreter. A new example file demonstrates benchmarking two string concatenation approaches, while changes to the interpreter module introduce a fast-path optimization for Text-to-Text concatenation operations to reduce overhead.

Changes

Cohort / File(s)	Summary
Benchmark Example `examples/benchmark_string_concat.wfl`	New example script comparing performance of two string concatenation methods (with "with" operator and "+" operator) across 50,000 iterations with timing measurements.
Interpreter Optimization `src/interpreter/mod.rs`	Added early-return fast-path in `perform_concatenation` and `add` functions that bypasses formatting for Text-to-Text concatenation, pre-allocating and constructing the result string directly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

⚡ Bolt: Optimize list literal evaluation #337: Modifies interpreter concatenation evaluation helpers and fast-paths that interact with the same text concatenation logic being optimized in this PR.
⚡ Bolt: Use Rc<str> for String Literals #321: Changes string literal and Value::Text construction in the same interpreter module, affecting how text values are handled alongside these concatenation optimizations.

Poem

🐰 A rabbit's ode to swiftness:

With strings that dance and loop so true,
Fast-paths emerge with something new,
Plus signs and words both race to win,
The benchmark counts where speed begins! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: optimizing string concatenation performance by replacing format! with direct string construction.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch bolt/string-concat-optimization-15997428297166563477

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Improves interpreter string concatenation performance by adding a fast path for Value::Text concatenations and includes a benchmark script to measure the impact.

Changes:

Added String::with_capacity + push_str fast path for Value::Text concatenation in the interpreter.
Updated + operator text concatenation to avoid format! overhead for Text + Text.
Added an example benchmark to compare with vs + concatenation performance.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/interpreter/mod.rs	Adds optimized string concatenation path for `Value::Text` operands.
examples/benchmark_string_concat.wfl	Adds a micro-benchmark to measure concatenation performance changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-23T12:50:58Z

        let result = format!("{left_val}{right_val}");
        Value::Text(Arc::from(result.as_str()))


Arc::from(result.as_str()) forces creating an Arc<str> from a &str, which typically requires allocating and copying. Since you already own the String, prefer converting the String directly (e.g., Arc::from(result) / Arc::<str>::from(result)) to avoid the extra copy and to keep this consistent with the new fast path.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@examples/benchmark_string_concat.wfl`:
- Line 10: The display statements concatenate the millisecond value directly to
"ms"; update the two display calls that read display "Concatenation (with): "
with (t_end - t_start) with "ms" (and the analogous line at the second
occurrence) to include a leading space in the "ms" literal (i.e., change "ms" to
" ms") so output formats as "154 ms" instead of "154ms".

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2877f0c and 7ee586e.

📒 Files selected for processing (2)

examples/benchmark_string_concat.wfl
src/interpreter/mod.rs

coderabbitai · 2026-02-23T12:53:45Z

+end repeat
+
+store t_end as current time in milliseconds
+display "Concatenation (with): " with (t_end - t_start) with "ms"


⚠️ Potential issue | 🟡 Minor

Missing space before "ms" produces run-together output.

Both display lines concatenate the millisecond value directly against "ms", producing e.g. "Concatenation (with): 154ms". The PR description implies the intended format is "154 ms".

🛠️ Proposed fix

-display "Concatenation (with): " with (t_end - t_start) with "ms" +display "Concatenation (with): " with (t_end - t_start) with " ms"

-display "Concatenation (+): " with (t_end2 - t_start2) with "ms" +display "Concatenation (+): " with (t_end2 - t_start2) with " ms"

Also applies to: 21-21

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@examples/benchmark_string_concat.wfl` at line 10, The display statements concatenate the millisecond value directly to "ms"; update the two display calls that read display "Concatenation (with): " with (t_end - t_start) with "ms" (and the analogous line at the second occurrence) to include a leading space in the "ms" literal (i.e., change "ms" to " ms") so output formats as "154 ms" instead of "154ms".

logbie · 2026-02-28T13:54:36Z

Closing in triage: this PR is currently conflicted (DIRTY) and superseded by newer clean PRs in the same optimization/refactor sequence. Reopen or rebase if you want this exact change revived.

google-labs-jules · 2026-02-28T13:56:20Z

Closing in triage: this PR is currently conflicted (DIRTY) and superseded by newer clean PRs in the same optimization/refactor sequence. Reopen or rebase if you want this exact change revived.

Understood. Acknowledging that this PR is being closed as superseded/conflicted and stopping work on this task.

Copilot AI review requested due to automatic review settings February 23, 2026 12:49

Copilot AI reviewed Feb 23, 2026

View reviewed changes

coderabbitai Bot reviewed Feb 23, 2026

View reviewed changes

logbie closed this Feb 28, 2026

Navigation Menu

Uh oh!

⚡ Bolt: Optimize string concatenation performance - #367

⚡ Bolt: Optimize string concatenation performance#367
logbie wants to merge 1 commit into
mainfrom
bolt/string-concat-optimization-15997428297166563477

logbie commented Feb 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

google-labs-jules Bot commented Feb 23, 2026

Uh oh!

claude Bot commented Feb 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Feb 23, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Feb 23, 2026

Uh oh!

logbie commented Feb 28, 2026

Uh oh!

google-labs-jules Bot commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		let result = format!("{left_val}{right_val}");
		Value::Text(Arc::from(result.as_str()))

Uh oh!

Conversation

logbie commented Feb 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

google-labs-jules Bot commented Feb 23, 2026

Uh oh!

claude Bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Complete ✅

🔍 Analysis Summary

✅ Strengths

🟡 Areas for Improvement

🔒 Security & Safety

🧪 Test Coverage Gap

⚡ Performance Assessment

🎯 Recommendation

Uh oh!

coderabbitai Bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

logbie commented Feb 28, 2026

Uh oh!

google-labs-jules Bot commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

logbie commented Feb 23, 2026 •

edited by coderabbitai Bot

Loading

claude Bot commented Feb 23, 2026 •

edited

Loading

coderabbitai Bot commented Feb 23, 2026 •

edited

Loading