Refactor list stdlib to use shared helper functions

[logbie]

This PR refactors the src/stdlib/list.rs module to reduce code duplication and improve maintainability by introducing shared helper functions in src/stdlib/helpers.rs.

Changes:

1. New Helpers: Added unary_list_op (for operations on a single list) and binary_list_val_op (for operations on a list and a value) to src/stdlib/helpers.rs. These helpers handle common tasks like argument count validation and type checking.
2. Refactoring: Updated src/stdlib/list.rs to utilize these new helpers for the following native functions:
   • push, pop, shift, unshift
   • clear, fill, unique, count
   • sort, reverse_list
   • find, every, some
3. Performance Optimization: The binary_list_val_op helper is implemented to pop the second argument from the input Vec<Value>, avoiding the need to clone the value as was done previously.

Verification:

• Ran cargo test to ensure all tests pass.
• Verified that list-related tests in src/stdlib/list.rs pass successfully.

---

PR created automatically by Jules for task 12141752616686828541 started by @logbie

Summary by CodeRabbit

• Refactor
  • Consolidated list-related logic into shared helpers to reduce duplication and centralize argument/type checks.
  • List operations (push, pop, shift, unshift, sort, reverse, find, every, some, unique, count, fill, etc.) now delegate to these helpers.
  • No changes to public APIs or user-visible behavior; error handling and behavior preserved.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Rate limit exceeded

@logbie has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9817d02 and 97ee8eb.

📒 Files selected for processing (1)

• src/stdlib/helpers.rs

📝 Walkthrough

Walkthrough

Added two generic list-operation helpers that centralize argument-count checking and list extraction, and refactored existing list primitives to use these helpers, moving per-call boilerplate into concise closures while preserving original behavior.

Changes

Cohort / File(s)	Summary
New List Operation Helpers src/stdlib/helpers.rs	Added pub fn unary_list_op(...) and pub fn binary_list_val_op(...) to validate arg counts, extract list(s), and delegate core work to provided closures.
List Primitive Refactoring src/stdlib/list.rs	Rewrote many list primitives (e.g., push, pop, shift, unshift, clear, sort, reverse_list, find, every, some, unique, count, fill) to call the new helpers and implement logic inside closures, removing repeated arg/type boilerplate.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Refactor stdlib argument validation helpers #311: Modifies src/stdlib/helpers.rs and src/stdlib/list.rs with related validation/helper changes that overlap with this refactor.

Poem

🐇 I nibble bytes and tidy hops,
I fold the lists and mend the ops,
From push to pop, I tidy the trail—
Cleaner hops make fewer fails. 🥕✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: refactoring list stdlib to use shared helper functions, which matches the core objective of introducing unary_list_op and binary_list_val_op helpers and updating list.rs to use them.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/list-stdlib-helpers-12141752616686828541

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors the list standard library module to reduce code duplication and improve maintainability by introducing reusable helper functions. The changes follow established patterns in the codebase for helper functions and include a minor performance optimization.

Changes:

• Added unary_list_op and binary_list_val_op helper functions to src/stdlib/helpers.rs following existing helper function patterns
• Refactored 11 list functions in src/stdlib/list.rs to use these new helpers, eliminating repetitive validation and type-checking code
• Implemented a performance optimization in binary_list_val_op that moves values from the args vector instead of cloning them

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/stdlib/helpers.rs	Added two new helper functions (unary_list_op and binary_list_val_op) with comprehensive documentation following codebase conventions
src/stdlib/list.rs	Refactored 11 native list functions (push, pop, shift, unshift, clear, fill, unique, count, sort, reverse_list, find, every, some) to use the new helper functions, reducing code duplication and improving consistency

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The PR description lists substantial refactors in src/stdlib/list.rs and new helper functions, but the actual diff shown here only adds documentation lines. If additional changes are expected, please ensure they are included in this PR (or update the description to match what’s actually being changed).