⚡ Bolt: [DRY Refactor] Introduce define_native helper to reduce boilerplate

[logbie]

Summary of Changes

• The Issue: The codebase had extensive duplication when registering native functions in the standard library modules (src/stdlib/*.rs). The pattern env.define("name", Value::NativeFunction("name", func)) was repeated over 100 times, violating the DRY principle and introducing a potential source of bugs if the string literal name in env.define did not match the string literal inside Value::NativeFunction.
• The Rational: Encapsulating this repeated pattern into a dedicated helper method reduces call-site boilerplate, improves code readability, and guarantees consistency by only requiring the function name to be passed as a string literal once.
• The Solution: Implemented a new define_native method on the Environment struct (src/interpreter/environment.rs) that accepts the name and function pointer, automatically constructing the Value::NativeFunction wrapper. Refactored all standard library modules (math, core, list, crypto, json, time, text, random, filesystem, pattern) to use env.define_native.

Verification Checklist

• cargo fmt executed and passed.
• cargo clippy returned no warnings or errors.
• All cargo test suites passed (100% success rate).

---

PR created automatically by Jules for task 2804966990401941479 started by @logbie

---

Summary by CodeRabbit

• Refactor
  • Streamlined internal native function registration mechanism across the standard library for improved code maintainability. All built-in functions continue to work as before with no user-facing changes.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f63dc319-f3a9-499f-a87f-9806b94c5dd8

📥 Commits

Reviewing files that changed from the base of the PR and between 6a37448 and d2fffe3.

📒 Files selected for processing (11)

• src/interpreter/environment.rs
• src/stdlib/core.rs
• src/stdlib/crypto.rs
• src/stdlib/filesystem.rs
• src/stdlib/json.rs
• src/stdlib/list.rs
• src/stdlib/math.rs
• src/stdlib/pattern.rs
• src/stdlib/random.rs
• src/stdlib/text.rs
• src/stdlib/time.rs

---

📝 Walkthrough

Walkthrough

This PR introduces a new define_native method to the Environment struct that simplifies registration of native functions, then refactors all stdlib modules to use this consolidated API instead of manually wrapping functions with Value::NativeFunction. The underlying behavior and exposed function names remain unchanged.

Changes

Cohort / File(s)	Summary
Environment API src/interpreter/environment.rs	Added new public method define_native that registers a native function by name, delegating to the existing define mechanism with Value::NativeFunction wrapping.
Stdlib Registrations src/stdlib/core.rs, src/stdlib/crypto.rs, src/stdlib/filesystem.rs, src/stdlib/json.rs, src/stdlib/list.rs, src/stdlib/math.rs, src/stdlib/pattern.rs, src/stdlib/random.rs, src/stdlib/text.rs, src/stdlib/time.rs	Unified native function registration across all stdlib modules by replacing env.define(..., Value::NativeFunction(...)) calls with env.define_native(...). Includes ~70+ function registrations (print, typeof, list operations, string operations, math functions, crypto, filesystem, JSON, time, pattern matching, and random utilities). No changes to function implementations or exported names.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

Possibly related PRs

• WebFirstLanguage/wfl#138: Modifies the Environment API in src/interpreter/environment.rs directly, complementing the new define_native addition.
• WebFirstLanguage/wfl#345: Updates stdlib registration code in multiple modules that this PR refactors (list.rs, math.rs, text.rs, etc.).

Poem

🐰 A hop and a skip through the stdlib,
Where functions now register with call,
From NativeFunction's wrapper so tight,
To define_native, clean and bright,
The registration API's unified might! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 47.06% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: introducing a define_native helper to reduce boilerplate in native function registration, which directly matches the PR's core objective of a DRY refactor.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch jules-refactor-native-function-define-2804966990401941479

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

[Copilot]

Pull request overview

This PR reduces boilerplate and eliminates duplicated string literals when registering standard-library native functions by introducing an Environment::define_native helper and updating stdlib modules to use it.

Changes:

• Added Environment::define_native(name, func) to wrap Value::NativeFunction(name, func) and call define.
• Refactored stdlib registration code across multiple modules to use env.define_native(...) instead of env.define(..., Value::NativeFunction(...)).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/interpreter/environment.rs	Adds define_native helper for consistent native-function registration.
src/stdlib/core.rs	Uses define_native for core native registrations and aliases.
src/stdlib/crypto.rs	Refactors crypto native registrations to define_native.
src/stdlib/filesystem.rs	Refactors filesystem native registrations to define_native.
src/stdlib/json.rs	Refactors JSON native registrations to define_native.
src/stdlib/list.rs	Refactors list native registrations and aliases to define_native.
src/stdlib/math.rs	Refactors math native registrations to define_native.
src/stdlib/pattern.rs	Refactors pattern native registrations to define_native.
src/stdlib/random.rs	Refactors random native registrations to define_native.
src/stdlib/text.rs	Refactors text native registrations and aliases to define_native.
src/stdlib/time.rs	Refactors time native registrations to define_native.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

[logbie]

Closing: bot-generated PR, cleaning up duplicates.