[JULES] Scheduled Maintenance: Refactor Text Parsing Logic

[logbie]

Summary of Changes

• The Issue: The native_parse_query_string, native_parse_cookies, and native_parse_form_urlencoded functions within src/stdlib/text.rs had duplicated boilerplate code for checking arguments, extracting text from Value, and wrapping the parsed results back into a Value::Object.
• The Rational: Consolidating this parsing logic DRYs up the codebase, improves maintainability, and decreases surface area for potential logic inconsistencies, ensuring they all correctly respect expect_text error flows and formatting quirks.
• The Solution: Implemented a unified helper function parse_text_to_object that abstracts away the repetitive parameter extraction, optional prefix trimming, key-value parsing, and object generation. Furthermore, added expect_object using the generate_expect! macro in src/stdlib/helpers.rs for consistency with existing interpreter data types extraction logic (expect_list, expect_text).

Verification Checklist

• cargo fmt executed and passed.
• cargo clippy returned no warnings or errors.
• All cargo test suites passed (100% success rate).

---

PR created automatically by Jules for task 3724693184136274828 started by @logbie

---

Summary by CodeRabbit

• New Features

  • Added expect_object function to validate and extract object values with detailed error reporting for type mismatches.

• Refactor

  • Consolidated internal text parsing logic to streamline query string, cookie, and form data parsing operations while maintaining full compatibility.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33875ab4-ab9d-4449-b3c9-59c76413ad5f

📥 Commits

Reviewing files that changed from the base of the PR and between 7d45082 and baa0d35.

📒 Files selected for processing (2)

• src/stdlib/helpers.rs
• src/stdlib/text.rs

---

📝 Walkthrough

Walkthrough

This PR adds a new expect_object type-extractor function to the helpers module and refactors text parsing functionality by introducing a centralized parse_text_to_object helper. Three parsing functions (native_parse_query_string, native_parse_cookies, native_parse_form_urlencoded) now delegate to this shared helper while maintaining their original signatures.

Changes

Cohort / File(s)	Summary
Type Extractor src/stdlib/helpers.rs	Added expect_object function generated via generate_expect! macro that extracts Object values from Value enum, returning Rc<RefCell<HashMap<String, Value>>> or a RuntimeError with type mismatch details.
Text Parsing Refactor src/stdlib/text.rs	Introduced parse_text_to_object helper to centralize argument validation, text extraction, and optional prefix trimming. Refactored native_parse_query_string, native_parse_cookies, and native_parse_form_urlencoded to delegate to this helper, removing duplicate code while preserving their distinct delimiters and trimming behaviors.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• [JULES] Scheduled Maintenance: Refactor redundant expect_* boilerplate in stdlib helpers #427 — Extends the expect_* helper family by adding expect_object via the same macro generation pattern
• [JULES] Refactor stdlib to eliminate redundant type-checking helpers #310 — Related consolidation of helper functions in src/stdlib/helpers.rs and refactoring of text-related stdlib code using centralized helpers
• Refactor parse_key_value_pairs to eliminate code duplication #385 — Parallels the refactoring in src/stdlib/text.rs to centralize key-value parsing across the same three native parsing functions

Poem

🐰 A helper here, a parser there,
Consolidating with utmost care,
Objects extracted, neat and clean,
Query strings parsed like never seen,
This code hops forward, light and bright!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: refactoring and consolidating duplicated text parsing logic in src/stdlib/text.rs. The [JULES] prefix indicates an automated maintenance task, and "Scheduled Maintenance" appropriately characterizes the nature of the work.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jules-scheduled-maintenance-3724693184136274828

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

[Copilot]

Pull request overview

This PR refactors the stdlib text parsing builtins to reduce duplicated argument/type extraction and parsing boilerplate, and extends the stdlib helper “expect_*” extractors for object values.

Changes:

• Introduces a shared parse_text_to_object helper to consolidate parse_query_string, parse_cookies, and parse_form_urlencoded implementations.
• Updates the three parsing builtins to delegate to the new helper (including optional prefix trimming for query strings).
• Adds expect_object via the generate_expect! macro for consistent Value extraction patterns.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/stdlib/text.rs	Refactors query/cookie/form parsing builtins to use a unified parsing helper.
src/stdlib/helpers.rs	Adds expect_object extractor generated by generate_expect!.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The refactor changes the parsing implementation for parse_query_string, parse_cookies, and parse_form_urlencoded, but there don’t appear to be any integration tests covering these builtins (including edge cases like leading '?', whitespace around cookie separators, valueless pairs, and percent-decoding). Adding tests would help prevent regressions in the shared parse_text_to_object helper.