[JULES] Refactor pattern extractions

[logbie]

Summary of Changes

• The Issue: There was extensive duplication of boilerplate match blocks used to safely extract Value::Text and Value::Pattern variants within the standard library's pattern functions (pattern_matches_native, pattern_find_native, pattern_find_all_native, native_pattern_replace, and native_pattern_split).
• The Rational: Consolidating value extraction logic aligns with DRY principles and reduces the surface area for bugs, significantly improving maintainability.
• The Solution: A generic expect_pattern macro function was created using generate_expect! in src/stdlib/helpers.rs. All previously redundant manual match blocks for patterns and text were replaced with robust expect_pattern and expect_text calls. In functions where detailed line and column context is required for error reporting, the generic helper errors were explicitly mapped back to retain source locations. Finally, a legacy integration test strictly asserting exact string values for the legacy manual error message was updated.

Verification Checklist

• cargo fmt executed and passed.
• cargo clippy returned no warnings or errors.
• All cargo test suites passed (100% success rate).

---

PR created automatically by Jules for task 15559435467753125591 started by @logbie

---

Summary by CodeRabbit

• New Features

  • Added a reusable pattern validation helper to improve input handling for pattern operations.

• Refactor

  • Consolidated text and pattern validation across pattern-related operations for clearer, more consistent behavior.

• Tests

  • Updated tests to expect refined error message wording for pattern-related argument errors.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 047c2ac5-3834-418b-913f-84e88a18648d

📥 Commits

Reviewing files that changed from the base of the PR and between d1ea353 and 09b4e0e.

📒 Files selected for processing (1)

• src/stdlib/pattern.rs

---

📝 Walkthrough

Walkthrough

Added a new expect_pattern extractor in src/stdlib/helpers.rs and refactored five pattern-related functions in src/stdlib/pattern.rs to use expect_text/expect_pattern instead of manual type checks; one test assertion in src/stdlib/pattern_test.rs was updated to match the new error message text.

Changes

Cohort / File(s)	Summary
Helper Infrastructure src/stdlib/helpers.rs	Added public expect_pattern(value: &Value) -> Result<Rc<crate::pattern::CompiledPattern>, RuntimeError> via generate_expect!, returning Rc::clone of the compiled pattern or a standardized "Expected a Pattern" runtime error.
Pattern Function Refactoring src/stdlib/pattern.rs	Replaced manual match-based validation in pattern_matches_native, pattern_find_native, pattern_find_all_native, native_pattern_replace, and native_pattern_split with expect_text/expect_pattern calls; preserved existing borrowing (as_ref()) and remapped errors to maintain line/column semantics.
Test Update src/stdlib/pattern_test.rs	Adjusted test_pattern_matches_native_wrong_first_arg_type to assert the error message contains "Expected text" instead of the previous "First argument" string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• [JULES] Scheduled Maintenance: Refactor redundant expect_* boilerplate in stdlib helpers #427: Continues the generate_expect!-based refactor by adding expect_pattern and updating callers to use centralized expect helpers.
• [JULES] Refactor stdlib to eliminate redundant type-checking helpers #310: Earlier refactor that centralized expect_* helpers; this change extends that pattern to pattern-related functions.

Poem

🐰 A helper hops out with a cheer,
Cloning patterns, making types clear,
Five functions now share one song,
Errors aligned, logic strong,
Hooray — less dupe, more cheer! 🎉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title '[JULES] Refactor pattern extractions' accurately reflects the main change: refactoring pattern extraction logic by replacing duplicated match boilerplate with generic helper functions.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jules-refactor-pattern-extractions-15559435467753125591

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

[Copilot]

Pull request overview

Refactors standard-library pattern functions to remove duplicated match boilerplate by centralizing Value variant extraction into reusable helpers.

Changes:

• Added a new expect_pattern extractor via generate_expect! in src/stdlib/helpers.rs.
• Updated pattern stdlib natives to use expect_text / expect_pattern instead of hand-written match blocks, preserving source location where needed.
• Updated a legacy unit test to assert the new (helper-generated) error message text.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/stdlib/pattern.rs	Replaces manual Value extraction with expect_text / expect_pattern and maps errors to retain line/column in interpreter-called natives.
src/stdlib/pattern_test.rs	Updates assertion to match the new standardized “Expected text …” error message.
src/stdlib/helpers.rs	Adds expect_pattern using the existing generate_expect! macro to standardize Pattern extraction/errors.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The # Errors section here is less specific than the other generate_expect! helpers in this file (e.g., expect_text, expect_list) which document that the error message includes both the expected type and the actual Value::type_name(). Consider aligning this doc comment with the established pattern so callers know what information will be included in the RuntimeError message.

Suggested change

	/// Returns `RuntimeError` if the value is not a Pattern.
	/// Returns `RuntimeError` if the value is not a Pattern. The error message includes
	/// both the expected type ("a Pattern") and the actual `Value::type_name()`.