ci: raise nightly Windows build timeout to 60 min (fixes cap-boundary cancellation) - #579
Conversation
The Nightly Build 'Build WFL for Windows' job had a 45-minute timeout-minutes cap. Build+test time on windows-latest has crept right up to that cap: 07-03 took 38.6 min, 07-04 took 43.5 min (1.5 min of headroom), and 07-05 (run 28731843110, sha 12860f1) blew past 45 min and was cancelled mid 'cargo wix' MSI packaging — the last step, after fmt/clippy/build/test/LSP/VS Code ext all passed. This was a timeout, not a code failure. Raise the cap to 60 min to restore headroom and stop cap-boundary cancellations. Release job (15 min, ubuntu) unchanged.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe nightly GitHub Actions workflow's Windows build job timeout was increased from 45 to 60 minutes. A minor end-of-file whitespace adjustment was also applied after the release job section. ChangesNightly Workflow Timeout Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Verified — the fix works, and the 45-min cap is confirmed too tight. I ran two nightlies on identical
The 45-min run got all the way through MSI packaging and the smoke test and was still cancelled at the cap on the last upload step — while the same code with a 60-min cap finished cleanly in 46m03s. The build genuinely needs more than 45 minutes now, so this one-line bump is the correct fix. Ready for review/merge. Posted by the WFL repo warden (automated triage pass). |
Problem
Last nightly — run 28731843110 (2026-07-05 06:21 UTC, sha
12860f1c) — ended incancelled, not success. TheBuild WFL for Windowsjob was cancelled at exactly its 45-minutetimeout-minutescap, right as it reached the finalcargo wixMSI-packaging step (fmt, clippy, build, test, LSP test, and VS Code extension had all already passed). This is a timeout, not a code failure.Root cause
Build+test wall-time on
windows-latesthas crept up to the cap:d190191b)576730bc)12860f1c)The margin was already razor-thin on 07-04; 07-05 crossed it.
Fix
Raise the
Build WFL for Windowsjobtimeout-minutesfrom 45 → 60 to restore headroom. One line; no code or behavior change. The release job (15 min, ubuntu) is untouched.Verification
Nightly only runs on
schedule/workflow_dispatch, so this PR’s push/PR CI does not exercise it. I am dispatching the nightly on this branch to confirm the full Windows pipeline completes green within the new budget; result will be linked in a follow-up comment.Opened by the WFL repo warden (automated triage pass).
Summary by CodeRabbit