Skip to content

ci: raise nightly Windows build timeout to 60 min (fixes cap-boundary cancellation) - #579

Merged
logbie merged 2 commits into
mainfrom
warden/fix-nightly-timeout
Jul 5, 2026
Merged

ci: raise nightly Windows build timeout to 60 min (fixes cap-boundary cancellation)#579
logbie merged 2 commits into
mainfrom
warden/fix-nightly-timeout

Conversation

@logbie

@logbie logbie commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Problem

Last nightly — run 28731843110 (2026-07-05 06:21 UTC, sha 12860f1c) — ended in cancelled, not success. The Build WFL for Windows job was cancelled at exactly its 45-minute timeout-minutes cap, right as it reached the final cargo wix MSI-packaging step (fmt, clippy, build, test, LSP test, and VS Code extension had all already passed). This is a timeout, not a code failure.

Root cause

Build+test wall-time on windows-latest has crept up to the cap:

Nightly Windows build duration Result
07-03 (d190191b) 38.6 min success
07-04 (576730bc) 43.5 min success (1.5 min headroom)
07-05 (12860f1c) > 45 min cancelled at cap

The margin was already razor-thin on 07-04; 07-05 crossed it.

Fix

Raise the Build WFL for Windows job timeout-minutes from 45 → 60 to restore headroom. One line; no code or behavior change. The release job (15 min, ubuntu) is untouched.

Verification

Nightly only runs on schedule/workflow_dispatch, so this PR’s push/PR CI does not exercise it. I am dispatching the nightly on this branch to confirm the full Windows pipeline completes green within the new budget; result will be linked in a follow-up comment.

Opened by the WFL repo warden (automated triage pass).

Summary by CodeRabbit

  • Chores
    • Increased the nightly Windows build timeout, helping long-running builds complete more reliably.
    • Applied a minor formatting cleanup at the end of the workflow file.

The Nightly Build 'Build WFL for Windows' job had a 45-minute
timeout-minutes cap. Build+test time on windows-latest has crept right
up to that cap: 07-03 took 38.6 min, 07-04 took 43.5 min (1.5 min of
headroom), and 07-05 (run 28731843110, sha 12860f1) blew past 45 min
and was cancelled mid 'cargo wix' MSI packaging — the last step, after
fmt/clippy/build/test/LSP/VS Code ext all passed. This was a timeout,
not a code failure.

Raise the cap to 60 min to restore headroom and stop cap-boundary
cancellations. Release job (15 min, ubuntu) unchanged.
Copilot AI review requested due to automatic review settings July 5, 2026 09:07
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 89031752-eeab-4dc5-b3dc-f4b9424929d1

📥 Commits

Reviewing files that changed from the base of the PR and between c4cfa92 and 5c805a7.

📒 Files selected for processing (1)
  • .github/workflows/nightly.yml

📝 Walkthrough

Walkthrough

The nightly GitHub Actions workflow's Windows build job timeout was increased from 45 to 60 minutes. A minor end-of-file whitespace adjustment was also applied after the release job section.

Changes

Nightly Workflow Timeout Update

Layer / File(s) Summary
Build timeout adjustment
.github/workflows/nightly.yml
Windows build job timeout-minutes increased from 45 to 60, plus a minor end-of-file whitespace adjustment.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: increasing the nightly Windows build timeout to 60 minutes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch warden/fix-nightly-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@logbie

logbie commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator Author

Verified — the fix works, and the 45-min cap is confirmed too tight.

I ran two nightlies on identical main code (commit 251b30d3) to A/B the timeout:

Run Timeout cap Build job Duration Outcome
28735679316 (main) 45 min fmt/clippy/build/test/LSP/ext/MSI/smoke all passed hit cap cancelled on the final upload-artifact step
28735740500 (this branch) 60 min full pipeline 46 min 3 s success (nightly release created)

The 45-min run got all the way through MSI packaging and the smoke test and was still cancelled at the cap on the last upload step — while the same code with a 60-min cap finished cleanly in 46m03s. The build genuinely needs more than 45 minutes now, so this one-line bump is the correct fix. Ready for review/merge.

Posted by the WFL repo warden (automated triage pass).

@logbie
logbie merged commit e308372 into main Jul 5, 2026
15 checks passed
@logbie
logbie deleted the warden/fix-nightly-timeout branch July 5, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants