Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: Phase 1 baseline & containment for #610 #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
test: Phase 1 baseline & containment for #610 #614
Changes from all commits
ef44622af91e57f627b4eda2c8a200a40db06e1e84e0d6a52b049d4ceca111e881b9ac875a58ce9ed1e0bf391b31f4da4b011062d7b7df1402dfef688fcb4b4bcd6d519d69752567cc8e25c84bedfbc7d418b477File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocker:
fuzz-checkis the only compile gate for the excluded fuzz workspace, but the write-capablebump-versionjob still hasneeds: [fmt, clippy-and-test, integration-tests, database-tests, run-wfl-programs]and omits this job. On a push tomain,fuzz-checkcan fail whilebump-versionstill commits, pushes, and tags a new version—contradicting the workflow’s “only after ALL checks pass” guarantee. The generated bump commit includes[skip ci], so that published version does not get a corrective rerun either. Addfuzz-checktobump-version.needsso a broken fuzz workspace cannot be versioned/tagged.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid gap, but deferring it out of this containment PR. I verified locally that flipping the CI step to
cargo clippy --workspace --all-targets -- -D warningsis not currently green — it surfaces ~10 pre-existing lint findings acrosswfl-lsp/wflpkgtest code that root-package clippy never saw: unused imports (lsp_end_to_end_validation_test.rs,lsp_performance_stability_test.rs), 3× unuseddocument_text(lsp_completion_test.rs), an unreadwarning_countfield, amap_or(false, …), a single-charpush_str, and afield_reassign_with_defaultinwflpkg. Clearing those is a worthwhile but separate lint-cleanup that touches two crates this Phase-1 containment PR otherwise doesn't, so I'd rather not balloon it here — tracking it as a follow-up. The related, actually-blocking CI gap on this workflow —fuzz-checkmissing frombump-version.needs— is fixed in this PR (4bcd6d5).Generated by Claude Code
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocker: this corrected row still conflicts with the tracked issue’s own current record. #600’s latest update still says #600 is the High alert’s fix vehicle, calls the dependency chain live, and raises the issue from post-production priority; #600 has no superseding correction. The correction on #610 does not repair the canonical #600 thread. Because this PR’s Phase-1 deliverable is an auditable open-issue inventory, leaving the source issue with the opposite classification makes the evidence incoherent. Please post or edit a superseding #600 update with the verified
RevocationOptions/CRL reachability disposition and keep the SNI priority separate. This is tracker-only; no additional code commit is needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping this note as written — the claim is accurate, not misleading.
if let/while letchains (thelet_chainsfeature) were stabilized in Rust 1.88.0 (2025-06-26), where they were the headline feature; they were unstable for years before that. This is exactly whyCargo.tomlpinsrust-version = "1.88", and its own comment says so: "features … (stabilized in Rust 1.88) throughout, so 1.88 is the true floor." Tying the MSRV to the concrete feature that forces it is more informative than only saying "Cargo enforces it," and the line already states the floor is declared but not gate-tested. No change.Generated by Claude Code
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.