Conversation
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Removes credential-bearing database URLs from the unsupported-scheme error path in the interpreter’s database connection helper, adds a regression test to prevent reintroducing the leak, and documents the security change in the Unreleased changelog.
Changes:
- Stop interpolating the full (potentially credential-bearing) database URL into the “unsupported scheme” runtime error.
- Add an async regression test asserting the unsupported-scheme error does not echo embedded secrets or the full URL.
- Add an Unreleased Security changelog entry describing the diagnostic redaction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/interpreter/database.rs |
Replaces unsupported-URL error formatting to avoid echoing the full URL; adds a regression test for secret/URL non-echoing. |
CHANGELOG.md |
Adds an Unreleased Security note documenting the diagnostic change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Err( | ||
| "Unsupported database URL scheme. Supported schemes: sqlite://, postgres://, postgresql://, mysql://, mariadb://" | ||
| .to_string(), | ||
| ) |
|
Superseded by #632, which preserves this security fix in the consolidated Rust-source hardening PR. The combined head is mergeable and all required CI checks are green. |
Summary
Security impact
An unsupported URL such as
oracle://user:password@host/dbwas copied verbatim into catchable runtime errors, console diagnostics, and default debug reports. Those diagnostics no longer disclose the supplied URL or embedded credentials.Validation
git diff --checkpassedPart of the Rust-source production-readiness work tracked in #610.