Update SqlExpressionEvaluator.java - #1673
Open
aschenzle wants to merge 5 commits into
Open
Conversation
Fixing a copy & paste mistake
jgaleotti
requested changes
Aug 11, 2026
jgaleotti
left a comment
jgaleotti
left a comment
Collaborator
There was a problem hiding this comment.
Please add a test case to exhibit the behaviour (i.e. a test case that fails since the expression checks only concreteLeftValue instead of concreteLeftValue and concreteRightValue
Collaborator
Author
I didn't need to add a test as the change made the existing test fail. The reason for the failure was a bad string parsing that didn't take timezone into account. Once I fixed that the test is passing again. |
jgaleotti
requested changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a copy & paste mistake