Adding DDB attribute type and making its parsing strict. Adding helpe… - #1676
Open
aschenzle wants to merge 6 commits into
Open
Adding DDB attribute type and making its parsing strict. Adding helpe…#1676aschenzle wants to merge 6 commits into
aschenzle wants to merge 6 commits into
Conversation
…r functions for the heuristic calculator so they can be reviewed in advance.
jgaleotti
requested changes
Aug 13, 2026
| * @param chunk one field-and-index component of a DynamoDB document path | ||
| * @return parsed field name and indexes to traverse | ||
| */ | ||
| private static ParsedChunk parseChunk(String chunk) { |
Collaborator
There was a problem hiding this comment.
Also this method seems quite a low level parser. Why can this be resolved by the dynamoDB parser?
Collaborator
Author
There was a problem hiding this comment.
We don't have a parser for Query Results (i.e. items) only for ConditionExpression, should I try to create a new parser using ANTLR4 (or reuse part of the Condition definition?).
jgaleotti
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r functions for the heuristic calculator so they can be reviewed in advance.