Skip to content

Adapt speech synthesis changes from 2.28 - #1054

Merged
magomez merged 1 commit into
WebPlatformForEmbedded:wpe-2.38from
Scony:speech-synthesis
Mar 21, 2023
Merged

Adapt speech synthesis changes from 2.28#1054
magomez merged 1 commit into
WebPlatformForEmbedded:wpe-2.38from
Scony:speech-synthesis

Conversation

@Scony

@Scony Scony commented Mar 21, 2023

Copy link
Copy Markdown

@Scony
Scony force-pushed the speech-synthesis branch from aecaa5e to b8c428d Compare March 21, 2023 13:38
- Add missing functions
- Add proper error handling (similar to WebPlatformForEmbedded#823 with optional as in WebPlatformForEmbedded#875) for both UIProcess and WebProcess
@Scony
Scony force-pushed the speech-synthesis branch from b8c428d to ef4c3c6 Compare March 21, 2023 13:38
@Scony
Scony marked this pull request as ready for review March 21, 2023 13:42
@magomez
magomez merged commit 906f263 into WebPlatformForEmbedded:wpe-2.38 Mar 21, 2023
@pgorszkowski-igalia

Copy link
Copy Markdown

Hi @Scony , are you able to build wpe-2.38 with ENABLE_SPEECH_SYNTHESIS=ON?

@Scony

Scony commented Mar 23, 2023

Copy link
Copy Markdown
Author

@pgorszkowski-igalia before/after my change there should be a compilation (linkage) error of undefined reference kind as by default there is no concrete speech synthesis implementation. If you provide some implementation (even dummy one) you will be able to build with ENABLE_SPEECH_SYNTHESIS=ON

@pgorszkowski-igalia

Copy link
Copy Markdown

In my case I get compilation error:

Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:352:72: error: ‘WEBKIT_TYPE_FLITE_SRC’ was not declared in this scope; did you mean ‘WEBKIT_TYPE_MEDIA_SRC’?
  352 |         gst_element_register(nullptr, "webkitflitesrc", GST_RANK_NONE, WEBKIT_TYPE_FLITE_SRC);

I think that there are still some missing patches from upstream. I am working on fix that and that is why I was surprised that it compiles in your case.

@Scony

Scony commented Mar 23, 2023

Copy link
Copy Markdown
Author

@pgorszkowski-igalia that looks unrelated. Are you sure this is regression from this change of mine?

@pgorszkowski-igalia

Copy link
Copy Markdown

@Scony: yes, it is definitely unrelated to your change(sorry for misunderstanding), but before/after your change the wpe is not compilable with ENABLE_SPEECH_SYNTHESIS=ON because of that error and my concerns was how you compiled/tested it (my assumption is that you did it not on clear wpe-2.38 branch - and that is why I asked you my question).

@pgorszkowski-igalia

Copy link
Copy Markdown

PR with fix for compilation of WPE with ENABLE_SPEECH_SYNTHESIS=ON: #1055

@Scony

Scony commented Mar 23, 2023

Copy link
Copy Markdown
Author

@Scony: yes, it is definitely unrelated to your change(sorry for misunderstanding), but before/after your change the wpe is not compilable with ENABLE_SPEECH_SYNTHESIS=ON because of that error and my concerns was how you compiled/tested it (my assumption is that you did it not on clear wpe-2.38 branch - and that is why I asked you my question).

ah, yes - I was compiling using wpe-2.38 from 21 Feb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants