Skip to content

fix: allow disabling concurrency wait pings - #8678

Merged
Wei-Shaw merged 1 commit into
Wei-Shaw:mainfrom
Cylion-bot:codex/disable-concurrency-ping
Nov 16, 2026
Merged

Wei-Shaw merged 1 commit into
Wei-Shaw:mainfrom
Cylion-bot:codex/disable-concurrency-ping

Conversation

@Cylion-bot

Copy link
Copy Markdown
Contributor

Allow concurrency.ping_interval: 0 to disable SSE pings while waiting
for concurrency slots.

Currently, sending and flushing a wait ping commits an HTTP 200 response
before the request reaches the upstream service. If the upstream later
returns an error, the gateway can no longer change the HTTP status code.
The client may therefore receive HTTP 200 even though the request failed.
If the downstream ensures not to timeout before sub2api, there is no need
to ping them.

Apply the same setting to user message queue waits and throttle delays.
Keep the default interval at 10 seconds and retain validation of nonzero
intervals within 5–30 seconds.

Validation:

  • Configuration validation tests passed.
  • Handler regression tests passed, covering disabled pings, enabled
    pings, successful slot acquisition, and HTTP 429 after a wait timeout.

@Wei-Shaw
Wei-Shaw merged commit bd3a878 into Wei-Shaw:main Nov 16, 2026
8 of 9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants