Repository navigation
fix: allow disabling concurrency wait pings - #8678
Merged
Wei-Shaw merged 1 commit intoNov 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
concurrency.ping_interval: 0to disable SSE pings while waitingfor concurrency slots.
Currently, sending and flushing a wait ping commits an HTTP 200 response
before the request reaches the upstream service. If the upstream later
returns an error, the gateway can no longer change the HTTP status code.
The client may therefore receive HTTP 200 even though the request failed.
If the downstream ensures not to timeout before sub2api, there is no need
to ping them.
Apply the same setting to user message queue waits and throttle delays.
Keep the default interval at 10 seconds and retain validation of nonzero
intervals within 5–30 seconds.
Validation:
pings, successful slot acquisition, and HTTP 429 after a wait timeout.