Skip to content

fix(gateway): retain sticky writes after client disconnects - #8726

Merged
Wei-Shaw merged 1 commit into
Wei-Shaw:mainfrom
r266-tech:codex/sticky-writeback-after-disconnect
Nov 16, 2026
Merged

Wei-Shaw merged 1 commit into
Wei-Shaw:mainfrom
r266-tech:codex/sticky-writeback-after-disconnect

Conversation

@r266-tech

Copy link
Copy Markdown
Contributor

Closes #8718.

After a successful Messages forward, the terminal sticky-session write uses the client's request context. A disconnect after the upstream has completed cancels that write, losing the binding or its TTL refresh.

Use a context that preserves request values and has a five-second deadline for this terminal write, and cancel it as soon as the write finishes. The existing account/group binding guard and failed-forward path retain their behavior.

Validation on Go 1.27.4 / macOS arm64:

  • Real GatewayHandler.Messages regression: 4 of 12 leaf cases fail on original main (530c5e3a); all 12 pass with the fix. Covers buffered/streaming responses, new bindings, refreshes, another bound account, failed forwarding, context values and deadlines.
  • go test -p=2 -tags=unit ./internal/handler -count=1: 2,089 pass / 1 conditional skip (test/subtest entries).
  • go test -p=2 -tags=integration ./internal/handler -count=1: 1,602 pass / 1 conditional skip.
  • Production cache adapter and go-redis client against local miniredis: the cancelled context returns context canceled; the detached context persists the binding and TTL and reads them back.
  • CI-pinned golangci-lint v2.14.0 across the backend: 0 issues.

The shared Go toolchain upgrade remains tracked by #8670. No live provider or user deployment was exercised.

AI disclosure: implemented and tested autonomously by an AI agent, without human review.

riofutab added a commit to riofutab/sub2api that referenced this pull request Nov 13, 2026
riofutab added a commit to riofutab/sub2api that referenced this pull request Nov 13, 2026
- Claude 链路:令牌轮换后 401 同账号重试,per-turn beta 保留轮次输出配置,Stainless 版本头与抬升后的 UA 对齐(Wei-Shaw#8737 Wei-Shaw#8742 Wei-Shaw#8731 Wei-Shaw#8726 Wei-Shaw#8724 Wei-Shaw#8698)。
- Codex/OpenAI 链路:Desktop 独立上下文原样转发并删除 fork 的 bootstrap 扫描器,分叉会话沿用父会话缓存键,刷新后的令牌在补充信息超时时仍保存(Wei-Shaw#8680 Wei-Shaw#8664 Wei-Shaw#8671 Wei-Shaw#8735 Wei-Shaw#8682 Wei-Shaw#8703)。
- 构建:Go 升到 1.27.4 修复 GO-2026-6859(Wei-Shaw#8670);前端 Gemini 用量条刷新不再跳动(Wei-Shaw#8740)。
- fork 带的 Wei-Shaw#8034 测试改为断言轮换后的凭据被保存,并为测试桩补齐 CAS 方法。
- 后端全量 unit、golangci-lint、前端 lint/typecheck/账号组件测试通过;repository 集成测试未跑。
@Wei-Shaw
Wei-Shaw merged commit 51e76a4 into Wei-Shaw:main Nov 16, 2026
8 of 9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] gateway sticky session: binding write-back fails with context canceled after the client disconnects

2 participants