Repository navigation
Conversation
Contributor
|
All contributors have signed the CLA. ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex Desktop can send browser tab context as an
agent.browser_tabsitem with nocall_id. The HTTP Responses handler currently rejects this input with400 invalid_request_errorbefore forwarding the request.This change extends the existing Codex context normalizer to recognize the Desktop ambient browser context wrapper and preserve its text in place. Real tool outputs still go through the existing validation.
A synthetic regression reproduces the 400 on
mainat328db26and passes with the fix. It covers mixed tool history, ordinary user messages, repeated normalization, and malformed context. The fullinternal/handlerunit suite passed with one skip.go test -tags unit ./internal/handler -count=1Fixes #8999